Tools/Scripts/webkitpy/layout_tests/port/base.py - Issue 560563005: Rename last two virtual test suites to complete VirtualTestSuite refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 560563005: Rename last two virtual test suites to complete VirtualTestSuite refactoring. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/virtual/prefer_compositing_to_lcd_text/scrollbars/rtl/div-absolute-expected.txt ('k') | Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/port/base.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base.py b/Tools/Scripts/webkitpy/layout_tests/port/base.py

index a8f0c2902699cf8446fae9b2168f6a8a32b916c2..70b61b0fe54b0d38b7631a63688ba75877dcb0df 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/base.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -1693,15 +1693,11 @@ class Port(object):

return self.path_from_webkit_base('LayoutTests', 'platform', platform)

class VirtualTestSuite(object):

- def __init__(self, prefix=None, name=None, base=None, args=None):

+ def __init__(self, prefix=None, base=None, args=None):

assert base

assert args

- # TODO(dpranke): Rename the legacy virtual test suites and update the expectations.

- if name:

- self.name = 'virtual/' + name

- else:

- assert prefix.find('/') == -1, "Virtual test suites prefixes cannot contain /'s: %s" % prefix

- self.name = 'virtual/' + prefix + '/' + base

+ assert prefix.find('/') == -1, "Virtual test suites prefixes cannot contain /'s: %s" % prefix

+ self.name = 'virtual/' + prefix + '/' + base

self.base = base

self.args = args

self.tests = {}