Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 560563005: Rename last two virtual test suites to complete VirtualTestSuite refactoring. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 1675 matching lines...) Expand 10 before | Expand all | Expand 10 after
1686 except OSError: 1686 except OSError:
1687 pass 1687 pass
1688 return True 1688 return True
1689 1689
1690 def _chromium_baseline_path(self, platform): 1690 def _chromium_baseline_path(self, platform):
1691 if platform is None: 1691 if platform is None:
1692 platform = self.name() 1692 platform = self.name()
1693 return self.path_from_webkit_base('LayoutTests', 'platform', platform) 1693 return self.path_from_webkit_base('LayoutTests', 'platform', platform)
1694 1694
1695 class VirtualTestSuite(object): 1695 class VirtualTestSuite(object):
1696 def __init__(self, prefix=None, name=None, base=None, args=None): 1696 def __init__(self, prefix=None, base=None, args=None):
1697 assert base 1697 assert base
1698 assert args 1698 assert args
1699 # TODO(dpranke): Rename the legacy virtual test suites and update the ex pectations. 1699 assert prefix.find('/') == -1, "Virtual test suites prefixes cannot cont ain /'s: %s" % prefix
1700 if name: 1700 self.name = 'virtual/' + prefix + '/' + base
1701 self.name = 'virtual/' + name
1702 else:
1703 assert prefix.find('/') == -1, "Virtual test suites prefixes cannot contain /'s: %s" % prefix
1704 self.name = 'virtual/' + prefix + '/' + base
1705 self.base = base 1701 self.base = base
1706 self.args = args 1702 self.args = args
1707 self.tests = {} 1703 self.tests = {}
1708 1704
1709 def __repr__(self): 1705 def __repr__(self):
1710 return "VirtualTestSuite('%s', '%s', %s)" % (self.name, self.base, self. args) 1706 return "VirtualTestSuite('%s', '%s', %s)" % (self.name, self.base, self. args)
1711 1707
1712 1708
1713 class PhysicalTestSuite(object): 1709 class PhysicalTestSuite(object):
1714 def __init__(self, base, args): 1710 def __init__(self, base, args):
1715 self.name = base 1711 self.name = base
1716 self.base = base 1712 self.base = base
1717 self.args = args 1713 self.args = args
1718 self.tests = set() 1714 self.tests = set()
1719 1715
1720 def __repr__(self): 1716 def __repr__(self):
1721 return "PhysicalTestSuite('%s', '%s', %s)" % (self.name, self.base, self .args) 1717 return "PhysicalTestSuite('%s', '%s', %s)" % (self.name, self.base, self .args)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698