Compile chrome://settings, part 5

Compile chrome://settings, part 5

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Committed: https://crrev.com/ad71b6663506c1a47091d65eeab9a5d61efe9dae
Cr-Commit-Position: refs/heads/master@{#295552}

[Dan Beam, 2014-09-11 21:42:48]

lgtm

https://codereview.chromium.org/560563004/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/handler_options.js (right):

https://codereview.chromium.org/560563004/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/handler_options.js:15: var HandlersValue;
nit: Handlers

https://codereview.chromium.org/560563004/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/language_add_language_overlay.js (right):

https://codereview.chromium.org/560563004/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/language_add_language_overlay.js:42: *         
       textDirection: string, nativeDisplayName: string}>}
indent off

[Vitaly Pavlenko, 2014-09-11 23:16:51]

https://chromiumcodereview.appspot.com/560563004/diff/1/chrome/browser/resour...
File chrome/browser/resources/options/handler_options.js (right):

https://chromiumcodereview.appspot.com/560563004/diff/1/chrome/browser/resour...
chrome/browser/resources/options/handler_options.js:15: var HandlersValue;
On 2014/09/11 21:42:48, Dan Beam wrote:
> nit: Handlers

Done.

https://chromiumcodereview.appspot.com/560563004/diff/1/chrome/browser/resour...
File chrome/browser/resources/options/language_add_language_overlay.js (right):

https://chromiumcodereview.appspot.com/560563004/diff/1/chrome/browser/resour...
chrome/browser/resources/options/language_add_language_overlay.js:42: *         
       textDirection: string, nativeDisplayName: string}>}
On 2014/09/11 21:42:48, Dan Beam wrote:
> indent off

Done.

[Vitaly Pavlenko, 2014-09-16 23:25:09]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-09-16 23:26:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/560563004/40001

[commit-bot: I haz the power, 2014-09-16 23:40:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 23:40:48]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Vitaly Pavlenko, 2014-09-16 23:55:39]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-09-16 23:58:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/560563004/40001

[commit-bot: I haz the power, 2014-09-17 01:41:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-17 01:41:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Vitaly Pavlenko, 2014-09-18 04:11:05]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-09-18 04:11:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/560563004/60001

[commit-bot: I haz the power, 2014-09-18 05:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 05:21:46]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Vitaly Pavlenko, 2014-09-18 19:48:15]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-09-18 19:48:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/560563004/80001

[commit-bot: I haz the power, 2014-09-18 21:34:51]

Committed patchset #5 (id:80001) as 74b347c13d49667e5f829b64f3bf1b2aae284a78

[commit-bot: I haz the power, 2014-09-18 21:36:17]

Patchset 5 (id:??) landed as
https://crrev.com/ad71b6663506c1a47091d65eeab9a5d61efe9dae
Cr-Commit-Position: refs/heads/master@{#295552}