Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: chrome/browser/resources/options/handler_options_list.js

Issue 560563004: Compile chrome://settings, part 5 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_make_public
Patch Set: fixed assert errors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/handler_options_list.js
diff --git a/chrome/browser/resources/options/handler_options_list.js b/chrome/browser/resources/options/handler_options_list.js
index 6e46da1984f6c059be45f7a2f506e8b29b8dc1e8..3a1334c3ad0ef7505b3d675d6b9e30b0776a3fba 100644
--- a/chrome/browser/resources/options/handler_options_list.js
+++ b/chrome/browser/resources/options/handler_options_list.js
@@ -17,7 +17,7 @@ cr.define('options', function() {
* @param {Object} entry A dictionary describing the handlers for a given
* protocol.
* @constructor
- * @extends {options.DeletableItemList}
+ * @extends {options.DeletableItem}
*/
function IgnoredHandlersListItem(entry) {
var el = cr.doc.createElement('div');
@@ -49,7 +49,10 @@ cr.define('options', function() {
},
};
-
+ /**
+ * @constructor
+ * @extends {options.DeletableItemList}
+ */
var IgnoredHandlersList = cr.ui.define('list');
IgnoredHandlersList.prototype = {
@@ -82,8 +85,6 @@ cr.define('options', function() {
},
};
-
-
/**
* Creates a new protocol / content handler list item.
*
@@ -110,6 +111,11 @@ cr.define('options', function() {
HandlerListItem.prototype = {
__proto__: ListItem.prototype,
+ /**
+ * @param {Handlers} data
+ * @param {{removeHandler: Function, setDefault: Function,
+ * clearDefault: Function}} delegate
+ */
buildWidget_: function(data, delegate) {
// Protocol.
var protocolElement = document.createElement('div');
@@ -223,7 +229,10 @@ cr.define('options', function() {
HandlersList.prototype = {
__proto__: List.prototype,
- /** @override */
+ /**
+ * @override
+ * @param {Object} entry
+ */
createItem: function(entry) {
return new HandlerListItem(entry);
},
@@ -239,7 +248,7 @@ cr.define('options', function() {
* Set the protocol handlers displayed by this list.
* See HandlerListItem for an example of the format the list should take.
*
- * @param {Object} list A list of protocols with their registered handlers.
+ * @param {!Array} list A list of protocols with their registered handlers.
*/
setHandlers: function(list) {
this.dataModel = new ArrayDataModel(list);
« no previous file with comments | « chrome/browser/resources/options/handler_options.js ('k') | chrome/browser/resources/options/home_page_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698