Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: pkg/analysis_server/lib/src/search/element_references.dart

Issue 560553003: Avoid false positives when searching for uses of a constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/search/element_references.dart
diff --git a/pkg/analysis_server/lib/src/search/element_references.dart b/pkg/analysis_server/lib/src/search/element_references.dart
index 0503f90f41d310bba33c71f090e285704fccb566..409b72dc3e75290f0340da654c69cc588d2d5867 100644
--- a/pkg/analysis_server/lib/src/search/element_references.dart
+++ b/pkg/analysis_server/lib/src/search/element_references.dart
@@ -30,7 +30,8 @@ class ElementReferencesComputer {
// find element references
futureGroup.add(_findElementsReferences(element));
// add potential references
- if (withPotential && _isMemberElement(element)) {
+ if (withPotential && _isMemberElement(element) &&
+ element is! ConstructorElement) {
scheglov 2014/09/09 20:45:17 Push this into _isMemberElement.
Paul Berry 2014/09/09 21:24:59 Done.
String name = element.displayName;
var matchesFuture = searchEngine.searchMemberReferences(name);
var resultsFuture = matchesFuture.then((List<SearchMatch> matches) {

Powered by Google App Engine
This is Rietveld 408576698