Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 560493003: Remove WebTouchEvent.changedTouches (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@input_remove_target_changed_touches
Project:
blink
Visibility:
Public.

Description

Remove WebTouchEvent.changedTouches This field is no longer needed or in use by embedders, and can be safely removed. This is part 4 of a 4-sided patch simplifying WebTouchEvent: 1) https://codereview.chromium.org/557863002/ 2) https://codereview.chromium.org/558773002/ 3) https://codereview.chromium.org/559693003/ 4) This change BUG=358132 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181834

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Really fix build #

Patch Set 4 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M Source/web/WebInputEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 2 3 5 chunks +0 lines, -5 lines 0 comments Download
M public/web/WebInputEvent.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
jdduke (slow)
pfeldman@: OK, last review in this CL chain (many thanks, and again, sorry for the ...
6 years, 3 months ago (2014-09-10 03:03:34 UTC) #2
pfeldman
lgtm
6 years, 3 months ago (2014-09-10 18:37:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560493003/1
6 years, 3 months ago (2014-09-11 15:37:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/12470) mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/19106) mac_gpu ...
6 years, 3 months ago (2014-09-11 15:39:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560493003/20001
6 years, 3 months ago (2014-09-11 15:42:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/10225) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/54692)
6 years, 3 months ago (2014-09-11 15:52:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560493003/40001
6 years, 3 months ago (2014-09-11 16:35:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/19117)
6 years, 3 months ago (2014-09-11 16:48:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560493003/60001
6 years, 3 months ago (2014-09-11 16:51:20 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 17:53:32 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 181834

Powered by Google App Engine
This is Rietveld 408576698