Source/web/tests/WebInputEventConversionTest.cpp - Issue 560493003: Remove WebTouchEvent.changedTouches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebInputEventConversionTest.cpp

Issue 560493003: Remove WebTouchEvent.changedTouches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@input_remove_target_changed_touches

Patch Set: Fix test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebInputEventConversionTest.cpp

diff --git a/Source/web/tests/WebInputEventConversionTest.cpp b/Source/web/tests/WebInputEventConversionTest.cpp

index 4ebd7fa8108c1eb03a20a996133662586fa9b539..810a1e4b84c3560f4727fa81d4f3490ae1bb7133 100644

--- a/Source/web/tests/WebInputEventConversionTest.cpp

+++ b/Source/web/tests/WebInputEventConversionTest.cpp

@@ -133,7 +133,6 @@ TEST(WebInputEventConversionTest, WebTouchEventBuilder)

WebTouchEventBuilder webTouchBuilder(view, documentRenderView, *touchEvent);

ASSERT_EQ(1u, webTouchBuilder.touchesLength);

- ASSERT_EQ(0u, webTouchBuilder.changedTouchesLength);

EXPECT_EQ(WebInputEvent::TouchStart, webTouchBuilder.type);

EXPECT_EQ(WebTouchPoint::StatePressed, webTouchBuilder.touches[0].state);

EXPECT_FLOAT_EQ(p0.screenPosition.x, webTouchBuilder.touches[0].screenPosition.x);

@@ -157,7 +156,6 @@ TEST(WebInputEventConversionTest, WebTouchEventBuilder)

WebTouchEventBuilder webTouchBuilder(view, documentRenderView, *touchEvent);

ASSERT_EQ(2u, webTouchBuilder.touchesLength);

- ASSERT_EQ(0u, webTouchBuilder.changedTouchesLength);

EXPECT_EQ(WebInputEvent::TouchMove, webTouchBuilder.type);

EXPECT_EQ(WebTouchPoint::StateMoved, webTouchBuilder.touches[0].state);

EXPECT_EQ(WebTouchPoint::StateStationary, webTouchBuilder.touches[1].state);

@@ -175,7 +173,6 @@ TEST(WebInputEventConversionTest, WebTouchEventBuilder)

WebTouchEventBuilder webTouchBuilder(view, documentRenderView, *touchEvent);

ASSERT_EQ(2u, webTouchBuilder.touchesLength);

- ASSERT_EQ(0u, webTouchBuilder.changedTouchesLength);

EXPECT_EQ(WebInputEvent::TouchEnd, webTouchBuilder.type);

EXPECT_EQ(WebTouchPoint::StateReleased, webTouchBuilder.touches[0].state);

EXPECT_EQ(WebTouchPoint::StateStationary, webTouchBuilder.touches[1].state);

@@ -193,7 +190,6 @@ TEST(WebInputEventConversionTest, WebTouchEventBuilder)

WebTouchEventBuilder webTouchBuilder(view, documentRenderView, *touchEvent);

ASSERT_EQ(2u, webTouchBuilder.touchesLength);

- ASSERT_EQ(0u, webTouchBuilder.changedTouchesLength);

EXPECT_EQ(WebInputEvent::TouchCancel, webTouchBuilder.type);

EXPECT_EQ(WebTouchPoint::StateCancelled, webTouchBuilder.touches[0].state);

EXPECT_EQ(WebTouchPoint::StateCancelled, webTouchBuilder.touches[1].state);

@@ -214,7 +210,6 @@ TEST(WebInputEventConversionTest, WebTouchEventBuilder)

WebTouchEventBuilder webTouchBuilder(view, documentRenderView, *touchEvent);

ASSERT_EQ(static_cast<unsigned>(WebTouchEvent::touchesLengthCap), webTouchBuilder.touchesLength);

- ASSERT_EQ(0u, webTouchBuilder.changedTouchesLength);

}

« no previous file with comments | « Source/web/WebInputEvent.cpp ('k') | public/web/WebInputEvent.h » ('j') | no next file with comments »