Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 560463004: Functions that return non-const internal data should not be const because it provides a loophole ar… (Closed)

Created:
6 years, 3 months ago by hendrikw
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Functions that return non-const internal data should not be const as it provides a loophole around const. I've removed const from platform_canvas() and sk_canvas(), if anyone tries to access these from a const instance of Canvas, it won't compile. Committed: https://crrev.com/788debf1d9ccd4387c68fd6d6294fa4c1392bba6 Cr-Commit-Position: refs/heads/master@{#295104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/gfx/canvas.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hendrikw
PTAL thanks!
6 years, 3 months ago (2014-09-16 15:47:53 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-16 16:45:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560463004/1
6 years, 3 months ago (2014-09-16 16:51:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5397afca9355ed955706419375eb7dbf15c93d94
6 years, 3 months ago (2014-09-16 18:16:49 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 18:19:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/788debf1d9ccd4387c68fd6d6294fa4c1392bba6
Cr-Commit-Position: refs/heads/master@{#295104}

Powered by Google App Engine
This is Rietveld 408576698