ui/gfx/canvas.h - Issue 560463004: Functions that return non-const internal data should not be const because it provides a loophole ar…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/canvas.h

Issue 560463004: Functions that return non-const internal data should not be const because it provides a loophole ar… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/canvas.h

diff --git a/ui/gfx/canvas.h b/ui/gfx/canvas.h

index f3d9486f9a6224cbb804aa2288ef56cecdbd5f46..c8fd2849bcdcb2f2c35ad838bc2bab60d40de638 100644

--- a/ui/gfx/canvas.h

+++ b/ui/gfx/canvas.h

@@ -421,8 +421,8 @@ class GFX_EXPORT Canvas {

const Rect& display_rect,

int flags);

- skia::PlatformCanvas* platform_canvas() const { return owned_canvas_.get(); }

- SkCanvas* sk_canvas() const { return canvas_; }

+ skia::PlatformCanvas* platform_canvas() { return owned_canvas_.get(); }

+ SkCanvas* sk_canvas() { return canvas_; }

float image_scale() const { return image_scale_; }

private:

« no previous file with comments | « no previous file | no next file » | no next file with comments »