Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: Source/core/editing/TextIterator.h

Issue 560333002: Avoid more temporary ranges in connection with various TextIterators. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/TextIterator.h
diff --git a/Source/core/editing/TextIterator.h b/Source/core/editing/TextIterator.h
index b86b7ebaa2d087ddbed00129cf0cea28cdea1045..239de029f45130cda84d536f07b668761221ffb1 100644
--- a/Source/core/editing/TextIterator.h
+++ b/Source/core/editing/TextIterator.h
@@ -107,12 +107,14 @@ public:
}
}
- PassRefPtrWillBeRawPtr<Range> range() const;
+ PassRefPtrWillBeRawPtr<Range> createRange() const;
Node* node() const;
+ Document* ownerDocument() const;
+ Node* startContainer() const;
+ Node* endContainer() const;
int startOffset() const;
int endOffset() const;
- Node* startContainer() const;
Position startPosition() const;
Position endPosition() const;
@@ -252,11 +254,10 @@ public:
m_textContainer.prependTo(output, m_textOffset, m_textLength);
}
- PassRefPtrWillBeRawPtr<Range> range() const;
-
Node* startContainer() const;
int endOffset() const;
Position startPosition() const;
+ Position endPosition() const;
private:
void init(Node* startNode, Node* endNode, int startOffset, int endOffset);
@@ -335,10 +336,13 @@ public:
void appendTextTo(BufferType& output) { m_textIterator.appendTextTo(output, m_runOffset); }
int characterOffset() const { return m_offset; }
- PassRefPtrWillBeRawPtr<Range> range() const;
+ PassRefPtrWillBeRawPtr<Range> createRange() const;
+ Document* ownerDocument() const;
Node* startContainer() const;
+ Node* endContainer() const;
int startOffset() const;
+ int endOffset() const;
Position startPosition() const;
Position endPosition() const;
@@ -362,8 +366,6 @@ public:
bool atEnd() const { return m_textIterator.atEnd(); }
- PassRefPtrWillBeRawPtr<Range> range() const;
-
Position endPosition() const;
private:

Powered by Google App Engine
This is Rietveld 408576698