Chromium Code Reviews| Index: Source/core/accessibility/AXRenderObject.cpp |
| diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp |
| index 48f8af107b7377f187f18f784f1cc8cebc3941bf..68d9f18c3145c551a1a122107843a9f8978a99d2 100644 |
| --- a/Source/core/accessibility/AXRenderObject.cpp |
| +++ b/Source/core/accessibility/AXRenderObject.cpp |
| @@ -1738,12 +1738,12 @@ VisiblePosition AXRenderObject::visiblePositionForIndex(int index) const |
| if (index <= 0) |
| return VisiblePosition(firstPositionInOrBeforeNode(node), DOWNSTREAM); |
| - RefPtrWillBeRawPtr<Range> range = Range::create(m_renderer->document()); |
| - range->selectNodeContents(node, IGNORE_EXCEPTION); |
| - CharacterIterator it(range.get()); |
| + Position start, end; |
| + bool selected = Range::selectNodeContents(node, start, end); |
|
yosin_UTC9
2014/09/12 01:02:24
It seems utilizing |selected| makes cleaner.
if (
Mads Ager (chromium)
2014/09/12 10:52:08
Done.
|
| + ASSERT_UNUSED(selected, selected); |
| + CharacterIterator it(start, end); |
| it.advance(index - 1); |
| - return VisiblePosition(Position(it.range()->endContainer(), it.range()->endOffset(), Position::PositionIsOffsetInAnch\ |
| -or), UPSTREAM); |
| + return VisiblePosition(Position(it.endContainer(), it.endOffset(), Position::PositionIsOffsetInAnchor), UPSTREAM); |
| } |
| int AXRenderObject::indexForVisiblePosition(const VisiblePosition& pos) const |