Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 560273004: Use AtomicString API directly (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
adamk, abarth-chromium
CC:
aboxhall, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, dmazzoni, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, Eric Willigers, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, Mike Lawther (Google), pdr., rjwright, rwlbuis, Stephen Chennney, shans, sof, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use AtomicString API directly Instead of going through string(), use the AtomicString API directly. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181868

Patch Set 1 #

Patch Set 2 : Add more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M Source/core/accessibility/AXObjectCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderQuote.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGHKernElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGVKernElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-11 23:00:18 UTC) #2
adamk
lgtm
6 years, 3 months ago (2014-09-11 23:38:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560273004/20001
6 years, 3 months ago (2014-09-11 23:40:33 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 01:54:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 181868

Powered by Google App Engine
This is Rietveld 408576698