Source/core/html/HTMLImageElement.cpp - Issue 560273004: Use AtomicString API directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLImageElement.cpp

Issue 560273004: Use AtomicString API directly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add more Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLImageElement.cpp

diff --git a/Source/core/html/HTMLImageElement.cpp b/Source/core/html/HTMLImageElement.cpp

index 25424dce0dae09425f02d3efe82930e195676ee8..6590e64a2d5c2d6e847a498c7e15da308d06366e 100644

--- a/Source/core/html/HTMLImageElement.cpp

+++ b/Source/core/html/HTMLImageElement.cpp

@@ -463,7 +463,7 @@ bool HTMLImageElement::isURLAttribute(const Attribute& attribute) const

return attribute.name() == srcAttr

|| attribute.name() == lowsrcAttr

|| attribute.name() == longdescAttr

- || (attribute.name() == usemapAttr && attribute.value().string()[0] != '#')

+ || (attribute.name() == usemapAttr && attribute.value()[0] != '#')

|| HTMLElement::isURLAttribute(attribute);

}

@@ -546,7 +546,7 @@ bool HTMLImageElement::isServerMap() const

const AtomicString& usemap = fastGetAttribute(usemapAttr);

// If the usemap attribute starts with '#', it refers to a map element in the document.

- if (usemap.string()[0] == '#')

+ if (usemap[0] == '#')

return false;

return document().completeURL(stripLeadingAndTrailingHTMLSpaces(usemap)).isEmpty();

« no previous file with comments | « Source/core/html/HTMLEmbedElement.cpp ('k') | Source/core/html/HTMLLinkElement.cpp » ('j') | no next file with comments »