chrome/browser/browser_browsertest.cc - Issue 560030: Refactored out JS specific part of modal dialog stack into its own class, exp...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_browsertest.cc

Issue 560030: Refactored out JS specific part of modal dialog stack into its own class, exp... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_browsertest.cc

===================================================================

--- chrome/browser/browser_browsertest.cc (revision 38222)

+++ chrome/browser/browser_browsertest.cc (working copy)

@@ -13,6 +13,7 @@

#include "chrome/browser/defaults.h"

#include "chrome/browser/extensions/extension_browsertest.h"

#include "chrome/browser/extensions/extensions_service.h"

+#include "chrome/browser/js_modal_dialog.h"

#include "chrome/browser/profile.h"

#include "chrome/browser/renderer_host/render_process_host.h"

#include "chrome/browser/tab_contents/tab_contents.h"

@@ -260,7 +261,8 @@

alert->AcceptWindow();

alert = ui_test_utils::WaitForAppModalDialog();

- EXPECT_FALSE(alert->is_before_unload_dialog());

+ EXPECT_FALSE(static_cast<JavaScriptAppModalDialog*>(alert)->

+ is_before_unload_dialog());

alert->AcceptWindow();

}

« no previous file with comments | « chrome/browser/app_modal_dialog_win.cc ('k') | chrome/browser/cookie_modal_dialog.h » ('j') | no next file with comments »