Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: chrome/browser/app_modal_dialog_win.cc

Issue 560030: Refactored out JS specific part of modal dialog stack into its own class, exp... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/app_modal_dialog_mac.mm ('k') | chrome/browser/browser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_modal_dialog_win.cc
===================================================================
--- chrome/browser/app_modal_dialog_win.cc (revision 38222)
+++ chrome/browser/app_modal_dialog_win.cc (working copy)
@@ -6,14 +6,14 @@
#include "base/logging.h"
#include "chrome/browser/views/jsmessage_box_dialog.h"
+#include "views/window/dialog_delegate.h"
#include "views/window/window.h"
AppModalDialog::~AppModalDialog() {
}
void AppModalDialog::CreateAndShowDialog() {
- dialog_ = new JavascriptMessageBoxDialog(this, message_text_,
- default_prompt_text_, display_suppress_checkbox_);
+ dialog_ = CreateNativeDialog();
DCHECK(dialog_->IsModal());
dialog_->ShowModalDialog();
}
@@ -25,19 +25,3 @@
void AppModalDialog::CloseModalDialog() {
dialog_->CloseModalDialog();
}
-
-int AppModalDialog::GetDialogButtons() {
- return dialog_->GetDialogButtons();
-}
-
-void AppModalDialog::AcceptWindow() {
- views::DialogClientView* client_view =
- dialog_->window()->GetClientView()->AsDialogClientView();
- client_view->AcceptWindow();
-}
-
-void AppModalDialog::CancelWindow() {
- views::DialogClientView* client_view =
- dialog_->window()->GetClientView()->AsDialogClientView();
- client_view->CancelWindow();
-}
Property changes on: chrome/browser/app_modal_dialog_win.cc
___________________________________________________________________
Name: svn:eol-style
+ LF
« no previous file with comments | « chrome/browser/app_modal_dialog_mac.mm ('k') | chrome/browser/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698