Cache snapshots of (mostly) immutable transformer phases.

sdk/lib/_internal/pub/lib/src/dart.dart

Index: sdk/lib/_internal/pub/lib/src/dart.dart
diff --git a/sdk/lib/_internal/pub/lib/src/dart.dart b/sdk/lib/_internal/pub/lib/src/dart.dart
index 50bdd2c678acc89748882c1735beda9cae7c1358..b1920ebcc597095025ac2e3728fc3ba243c75a49 100644
--- a/sdk/lib/_internal/pub/lib/src/dart.dart
+++ b/sdk/lib/_internal/pub/lib/src/dart.dart
@@ -6,6 +6,7 @@
 library pub.dart;
 
 import 'dart:async';
+import 'dart:io';
 import 'dart:isolate';
 
 import 'package:analyzer/analyzer.dart';
@@ -18,6 +19,7 @@ import '../../../compiler/implementation/filenames.dart'
 
 import '../../asset/dart/serialize.dart';
 import 'io.dart';
+import 'log.dart' as log;
 
 import 'utils.dart';
 /// Interface to communicate with dart2js.
@@ -147,9 +149,18 @@ class _DirectiveCollector extends GeneralizingAstVisitor {
 /// passed to the [main] method of the code being run; the caller is responsible
 /// for using this to establish communication with the isolate.
 ///
+/// If [snapshot] is passed, the isolate will be loaded from that path if it
+/// exists. Otherwise, a snapshot of the isolate's code will be saved to that
+/// path once the isolate is loaded.
+///
 /// Returns a Future that will fire when the isolate has been spawned. If the
 /// isolate fails to spawn, the Future will complete with an error.
-Future runInIsolate(String code, message) {
+Future runInIsolate(String code, message, {String snapshot}) {
+  if (snapshot != null && fileExists(snapshot)) {
+    log.fine("Spawning isolate from $snapshot.");
+    return Chain.track(Isolate.spawnUri(path.toUri(snapshot), [], message));
+  }
+
   return withTempDir((dir) {
     var dartPath = path.join(dir, 'runInIsolate.dart');
     writeTextFile(dartPath, code, dontLogContents: true);
@@ -164,6 +175,19 @@ Future runInIsolate(String code, message) {
       return new Future.error(
           new CrossIsolateException.deserialize(response['error']),
           new Chain.current());
+    }).then((_) {

[Bob Nystrom, 2014/09/10 17:58:10]

await?

[nweiz, 2014/09/10 23:30:13]

Done.

+      if (snapshot == null) return null;
+      ensureDir(path.dirname(snapshot));
+      return runProcess(Platform.executable, [
+        '--snapshot=$snapshot', dartPath
+      ]).then((result) {
+        if (result.success) return;
+        // Don't emit a fatal error here, since we don't want to crash the
+        // otherwise successful isolate load.
+        log.warning("Failed to compile a snapshot to "
+            "${path.relative(snapshot)}:\n" +
+            result.stderr.join("\n"));

[Bob Nystrom, 2014/09/10 17:58:10]

I think this fits on the previous line.

[nweiz, 2014/09/10 23:30:12]

Done.

+      });
     });
   });
 }