Cache snapshots of (mostly) immutable transformer phases.

sdk/lib/_internal/pub/lib/src/barback/transformer_loader.dart

Index: sdk/lib/_internal/pub/lib/src/barback/transformer_loader.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/transformer_loader.dart b/sdk/lib/_internal/pub/lib/src/barback/transformer_loader.dart
new file mode 100644
index 0000000000000000000000000000000000000000..ebe7f85b16fabaeb679b83c0ccd268fd3fe09f89
--- /dev/null
+++ b/sdk/lib/_internal/pub/lib/src/barback/transformer_loader.dart
@@ -0,0 +1,128 @@
+// Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library pub.barback.transformer_loader;
+
+import 'dart:async';
+
+import 'package:barback/barback.dart';
+
+import '../log.dart' as log;
+import '../utils.dart';
+import 'asset_environment.dart';
+import 'barback_server.dart';
+import 'dart2js_transformer.dart';
+import 'excluding_transformer.dart';
+import 'transformer_config.dart';
+import 'transformer_id.dart';
+import 'transformer_isolate.dart';
+
+/// A class that loads transformers defined in specific files.
+class TransformerLoader {
+  final AssetEnvironment _environment;
+
+  final BarbackServer _transformerServer;
+
+  final _isolates = new Map<TransformerId, TransformerIsolate>();
+
+  final _transformers = new Map<TransformerConfig, Set<Transformer>>();
+
+  /// The packages that use each transformer id.
+  ///
+  /// Used for error reporting.
+  final _transformerUsers = new Map<TransformerId, Set<String>>();
+
+  TransformerLoader(this._environment, this._transformerServer) {
+    for (var package in _environment.graph.packages.values) {
+      for (var config in unionAll(package.pubspec.transformers)) {
+        _transformerUsers.putIfAbsent(config.id, () => new Set<String>())
+            .add(package.name);
+      }
+    }
+  }
+
+  /// Loads a transformer plugin isolate that imports the transformer libraries
+  /// indicated by [ids].
+  ///
+  /// Once the returned future completes, transformer instances from this
+  /// isolate can be created using [transformersFor] or [transformersForPhase].
+  ///
+  /// This will skip any ids that have already been loaded.

[Bob Nystrom, 2014/09/10 17:58:10]

"will skip" -> "skips".

[nweiz, 2014/09/10 23:30:12]

Done.

+  Future load(Iterable<TransformerId> ids, {String snapshot}) {
+    ids = ids.where((id) => !_isolates.containsKey(id)).toList();
+    if (ids.isEmpty) return new Future.value();
+
+    return log.progress("Loading ${toSentence(ids)} transformers", () {
+      return TransformerIsolate.spawn(_environment, _transformerServer, ids,
+          snapshot: snapshot);
+    }).then((isolate) {

[Bob Nystrom, 2014/09/10 17:58:10]

await?

[nweiz, 2014/09/10 23:30:12]

I didn't change this because this is just copied from load_all_transformers, but
sure.

+      for (var id in ids) {
+        _isolates[id] = isolate;
+      }
+    });
+  }
+
+  /// Instantiates and returns all transformers in the library indicated by
+  /// [config] with the given configuration.
+  ///
+  /// If this is called before the library has been loaded into an isolate via
+  /// [load], it will return an empty set.
+  Future<Set<Transformer>> transformersFor(TransformerConfig config) {

[Bob Nystrom, 2014/09/10 17:58:10]

This can definitely benefit from await.

[nweiz, 2014/09/10 23:30:12]

Done.

+    if (_transformers.containsKey(config)) {
+      return new Future.value(_transformers[config]);
+    } else if (_isolates.containsKey(config.id)) {
+      return _isolates[config.id].create(config).then((transformers) {
+        if (transformers.isNotEmpty) {
+          _transformers[config] = transformers;
+          return transformers;
+        }
+
+        var message = "No transformers";
+        if (config.configuration.isNotEmpty) {
+          message += " that accept configuration";
+        }
+
+        var location;
+        if (config.id.path == null) {
+          location = 'package:${config.id.package}/transformer.dart or '
+            'package:${config.id.package}/${config.id.package}.dart';
+        } else {
+          location = 'package:$config.dart';
+        }
+
+        var users = toSentence(ordered(_transformerUsers[config.id]));
+        fail("$message were defined in $location,\n"
+            "required by $users.");
+      });
+    } else if (config.id.package != '\$dart2js') {
+      return new Future.value(new Set());
+    }
+
+    var transformer;
+    try {
+      transformer = new Dart2JSTransformer.withSettings(_environment,
+          new BarbackSettings(config.configuration, _environment.mode));
+    } on FormatException catch (error, stackTrace) {
+      fail(error.message, error, stackTrace);
+    }
+
+    // Handle any exclusions.
+    _transformers[config] = new Set.from(
+        [ExcludingTransformer.wrap(transformer, config)]);
+    return new Future.value(_transformers[config]);
+  }
+
+  /// Loads all transformers defined in each phase of [phases].
+  ///
+  /// If any library hasn't yet been loaded via [load], it will be ignored.
+  Future<List<Set<Transformer>>> transformersForPhases(
+      Iterable<Set<TransformerConfig>> phases) {
+    return Future.wait(phases.map((phase) {
+      return waitAndPrintErrors(phase.map(transformersFor)).then(unionAll);
+    })).then((phases) {
+      // Return a growable list so that callers can add phases.
+      return phases.toList();
+    });
+  }
+}