Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 559543002: Don't clear CA cert when configuring an existing VPN. (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't clear CA cert when configuring an existing VPN. Bug was introduced in https://codereview.chromium.org/485083002 . BUG=410537 Committed: https://crrev.com/49ebec377ae7d10f80ddb8307342ea115eca8d90 Cr-Commit-Position: refs/heads/master@{#293951}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M chrome/browser/chromeos/options/vpn_config_view.cc View 2 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pneubeck (no reviews)
ptal
6 years, 3 months ago (2014-09-09 14:30:06 UTC) #3
stevenjb
lgtm
6 years, 3 months ago (2014-09-09 15:33:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/559543002/20001
6 years, 3 months ago (2014-09-09 15:34:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 1712d988b17cff58b8eb804f85a2350dcb2cf746
6 years, 3 months ago (2014-09-09 16:29:58 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49ebec377ae7d10f80ddb8307342ea115eca8d90
Cr-Commit-Position: refs/heads/master@{#293951}

Powered by Google App Engine
This is Rietveld 408576698