Issue 485083002: Fix network configurations that use the system CA certs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 485083002: Fix network configurations that use the system CA certs. (Closed)

Created:
6 years, 4 months ago by pneubeck (no reviews)

Modified:
6 years, 4 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix network configurations that use the system CA certs. Before, for EAP, the network configuration UI sent a list with an empty string to Shill instead of an empty list. For VPNs, CACertPEM property was not sent at all and thus potentially not deleting a previously selected CA cert. Now, in all cases, if no CA cert is selected, an empty list will be sent to Shill. BUG=405067 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290597

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	chrome/browser/chromeos/options/vpn_config_view.cc	View		2 chunks	+8 lines, -10 lines	0 comments	Download
	M	chrome/browser/chromeos/options/wifi_config_view.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pneubeck (no reviews)

The CQ bit was checked by pneubeck@chromium.org

6 years, 4 months ago (2014-08-19 16:04:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/485083002/1

6 years, 4 months ago (2014-08-19 16:05:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 290597

Expand Messages | Collapse Messages