Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 559433002: Merge FontPlatformDataHarfBuzz and FontPlatformData headers (Closed)

Created:
6 years, 3 months ago by Dominik Röttsches
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Merge FontPlatformDataHarfBuzz and FontPlatformData headers Those two files were split apart and redundantly copied for non-Mac and Mac platforms. This is an attempt an unifying them, as a preparation for removing the CoreText shaper. We can merge the implementations in FontPlatformDataHarfBuzz.cpp and FontPlatformData.cpp as a next step. This is a reland after the change got reverted again in 7443ae0830de1c3483 due to Windows build breakge. BUG=334269, 411287 R=eae,arv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -309 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/FontPlatformData.h View 2 chunks +133 lines, -91 lines 0 comments Download
M Source/platform/fonts/FontPlatformData.cpp View 4 chunks +59 lines, -32 lines 0 comments Download
M Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm View 8 chunks +25 lines, -17 lines 0 comments Download
D Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.h View 1 chunk +0 lines, -146 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp View 3 chunks +7 lines, -2 lines 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzFaceCoreText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/linux/FontPlatformDataLinux.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/mac/FontCacheMac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/fonts/mac/FontMac.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/mac/SimpleFontDataMac.mm View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mac/WebFontCache.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dominik Röttsches
One more try, could you take a look, Emil? The windows fix was to add ...
6 years, 3 months ago (2014-09-09 11:53:23 UTC) #1
eae
LGTM
6 years, 3 months ago (2014-09-09 15:58:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/559433002/1
6 years, 3 months ago (2014-09-09 15:58:55 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 16:02:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181655

Powered by Google App Engine
This is Rietveld 408576698