Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1663)

Unified Diff: Source/platform/fonts/FontPlatformData.cpp

Issue 559433002: Merge FontPlatformDataHarfBuzz and FontPlatformData headers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/FontPlatformData.h ('k') | Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/FontPlatformData.cpp
diff --git a/Source/platform/fonts/FontPlatformData.cpp b/Source/platform/fonts/FontPlatformData.cpp
index 4048be0974b715c2521745dfe9899a54aafadf08..8fefa55746d0f89c9e24a91bbc4fd40e0ca8ab5e 100644
--- a/Source/platform/fonts/FontPlatformData.cpp
+++ b/Source/platform/fonts/FontPlatformData.cpp
@@ -21,6 +21,8 @@
#include "config.h"
#include "platform/fonts/FontPlatformData.h"
+#include "SkTypeface.h"
+#include "platform/fonts/harfbuzz/HarfBuzzFace.h"
#include "wtf/HashMap.h"
#include "wtf/text/StringHash.h"
#include "wtf/text/WTFString.h"
@@ -29,73 +31,80 @@
#include "platform/fonts/harfbuzz/HarfBuzzFace.h"
#endif
+using namespace std;
+
namespace blink {
FontPlatformData::FontPlatformData(WTF::HashTableDeletedValueType)
- : m_syntheticBold(false)
- , m_syntheticOblique(false)
+ : m_textSize(0)
+ , m_syntheticBold(false)
+ , m_syntheticItalic(false)
, m_orientation(Horizontal)
- , m_size(0)
+ , m_isColorBitmapFont(false)
+ , m_isCompositeFontReference(false)
, m_widthVariant(RegularWidth)
#if OS(MACOSX)
- , m_font(hashTableDeletedFontValue())
+ , m_font(nullptr)
#endif
- , m_isColorBitmapFont(false)
- , m_isCompositeFontReference(false)
+ , m_isHashTableDeletedValue(true)
{
}
FontPlatformData::FontPlatformData()
- : m_syntheticBold(false)
- , m_syntheticOblique(false)
+ : m_textSize(0)
+ , m_syntheticBold(false)
+ , m_syntheticItalic(false)
, m_orientation(Horizontal)
- , m_size(0)
+ , m_isColorBitmapFont(false)
+ , m_isCompositeFontReference(false)
, m_widthVariant(RegularWidth)
#if OS(MACOSX)
- , m_font(0)
+ , m_font(nullptr)
#endif
- , m_isColorBitmapFont(false)
- , m_isCompositeFontReference(false)
+ , m_isHashTableDeletedValue(false)
{
}
-FontPlatformData::FontPlatformData(float size, bool syntheticBold, bool syntheticOblique, FontOrientation orientation, FontWidthVariant widthVariant)
- : m_syntheticBold(syntheticBold)
- , m_syntheticOblique(syntheticOblique)
+FontPlatformData::FontPlatformData(float size, bool syntheticBold, bool syntheticItalic, FontOrientation orientation, FontWidthVariant widthVariant)
+ : m_textSize(size)
+ , m_syntheticBold(syntheticBold)
+ , m_syntheticItalic(syntheticItalic)
, m_orientation(orientation)
- , m_size(size)
+ , m_isColorBitmapFont(false)
+ , m_isCompositeFontReference(false)
, m_widthVariant(widthVariant)
#if OS(MACOSX)
- , m_font(0)
+ , m_font(nullptr)
#endif
- , m_isColorBitmapFont(false)
- , m_isCompositeFontReference(false)
+ , m_isHashTableDeletedValue(false)
{
}
#if OS(MACOSX)
-FontPlatformData::FontPlatformData(CGFontRef cgFont, float size, bool syntheticBold, bool syntheticOblique, FontOrientation orientation, FontWidthVariant widthVariant)
- : m_syntheticBold(syntheticBold)
- , m_syntheticOblique(syntheticOblique)
+FontPlatformData::FontPlatformData(CGFontRef cgFont, float size, bool syntheticBold, bool syntheticItalic, FontOrientation orientation, FontWidthVariant widthVariant)
+ : m_textSize(size)
+ , m_syntheticBold(syntheticBold)
+ , m_syntheticItalic(syntheticItalic)
, m_orientation(orientation)
- , m_size(size)
- , m_widthVariant(widthVariant)
- , m_font(0)
- , m_cgFont(cgFont)
, m_isColorBitmapFont(false)
, m_isCompositeFontReference(false)
+ , m_widthVariant(widthVariant)
+ , m_font(nullptr)
+ , m_cgFont(cgFont)
+ , m_isHashTableDeletedValue(false)
{
}
#endif
FontPlatformData::FontPlatformData(const FontPlatformData& source)
- : m_syntheticBold(source.m_syntheticBold)
- , m_syntheticOblique(source.m_syntheticOblique)
+ : m_textSize(source.m_textSize)
+ , m_syntheticBold(source.m_syntheticBold)
+ , m_syntheticItalic(source.m_syntheticItalic)
, m_orientation(source.m_orientation)
- , m_size(source.m_size)
- , m_widthVariant(source.m_widthVariant)
, m_isColorBitmapFont(source.m_isColorBitmapFont)
, m_isCompositeFontReference(source.m_isCompositeFontReference)
+ , m_widthVariant(source.m_widthVariant)
+ , m_isHashTableDeletedValue(false)
{
platformDataInit(source);
}
@@ -107,9 +116,9 @@ const FontPlatformData& FontPlatformData::operator=(const FontPlatformData& othe
return *this;
m_syntheticBold = other.m_syntheticBold;
- m_syntheticOblique = other.m_syntheticOblique;
+ m_syntheticItalic = other.m_syntheticItalic;
m_orientation = other.m_orientation;
- m_size = other.m_size;
+ m_textSize = other.m_textSize;
m_widthVariant = other.m_widthVariant;
m_isColorBitmapFont = other.m_isColorBitmapFont;
m_isCompositeFontReference = other.m_isCompositeFontReference;
@@ -117,4 +126,22 @@ const FontPlatformData& FontPlatformData::operator=(const FontPlatformData& othe
return platformDataAssign(other);
}
+bool FontPlatformData::operator==(const FontPlatformData& a) const
+{
+
+ return platformIsEqual(a)
+ && m_textSize == a.m_textSize
+ && m_isHashTableDeletedValue == a.m_isHashTableDeletedValue
+ && m_syntheticBold == a.m_syntheticBold
+ && m_syntheticItalic == a.m_syntheticItalic
+ && m_orientation == a.m_orientation
+#if !OS(MACOSX)
+ && m_style == a.m_style
+#endif
+ && m_isColorBitmapFont == a.m_isColorBitmapFont
+ && m_isCompositeFontReference == a.m_isCompositeFontReference
+ && m_widthVariant == a.m_widthVariant;
+}
+
+
} // namespace blink
« no previous file with comments | « Source/platform/fonts/FontPlatformData.h ('k') | Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698