Hotword Audio Verification app: control the hotword settings

chrome/browser/extensions/api/hotword_private/hotword_private_api.h

Index: chrome/browser/extensions/api/hotword_private/hotword_private_api.h
diff --git a/chrome/browser/extensions/api/hotword_private/hotword_private_api.h b/chrome/browser/extensions/api/hotword_private/hotword_private_api.h
index 8013621860e4b362d463bd8b83e6596cc8e381c1..62a8f0cd22244e662d2f3740a3bb765907ccf359 100644
--- a/chrome/browser/extensions/api/hotword_private/hotword_private_api.h
+++ b/chrome/browser/extensions/api/hotword_private/hotword_private_api.h
@@ -69,6 +69,19 @@ class HotwordPrivateSetAudioLoggingEnabledFunction
   virtual bool RunSync() OVERRIDE;
 };
 
+class HotwordPrivateSetHotwordAlwaysOnSearchEnabledFunction

[rpetterson, 2014/09/11 20:14:17]

Perhaps just SetAlwaysOnSearchEnabled? I think the second Hotword is redundant
since it's in the hotword private api. That would make it a bit more manageable
in length as well.

[kcarattini, 2014/09/12 01:02:07]

The name of the pref being changed in prefs.h is kHotwordAlwaysOnSearchEnabled,
and I like the consistency of having the function name match the pref name. Let
me know if you feel strongly about this.

[rpetterson, 2014/09/12 03:03:32]

We only use SetEnabled for the pref call kHotwordSearchEnabled :) But I do not
feel strongly. It just seemed rather long and I was offering a suggestion.

[kcarattini, 2014/09/12 05:17:56]

Acknowledged.

+    : public ChromeSyncExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION("hotwordPrivate.setHotwordAlwaysOnSearchEnabled",
+                             HOTWORDPRIVATE_SETHOTWORDALWAYSONSEARCHENABLED)
+
+ protected:
+  virtual ~HotwordPrivateSetHotwordAlwaysOnSearchEnabledFunction() {}
+
+  // ExtensionFunction:
+  virtual bool RunSync() OVERRIDE;
+};
+
 class HotwordPrivateGetStatusFunction : public ChromeSyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("hotwordPrivate.getStatus",