Hotword Audio Verification app: control the hotword settings

chrome/browser/extensions/api/hotword_private/hotword_private_api.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_HOTWORD_PRIVATE_HOTWORD_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_HOTWORD_PRIVATE_HOTWORD_PRIVATE_API_H_
 
 #include "base/prefs/pref_change_registrar.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/chrome_extension_function.h"
@@ skipping 51 matching lines @@
   DECLARE_EXTENSION_FUNCTION("hotwordPrivate.setAudioLoggingEnabled",
                              HOTWORDPRIVATE_SETAUDIOLOGGINGENABLED)
 
  protected:
   virtual ~HotwordPrivateSetAudioLoggingEnabledFunction() {}
 
   // ExtensionFunction:
   virtual bool RunSync() OVERRIDE;
 };
 
+class HotwordPrivateSetHotwordAlwaysOnSearchEnabledFunction

[rpetterson, 2014/09/11 20:14:17]

Perhaps just SetAlwaysOnSearchEnabled? I think the second Hotword is redundant
since it's in the hotword private api. That would make it a bit more manageable
in length as well.

[kcarattini, 2014/09/12 01:02:07]

The name of the pref being changed in prefs.h is kHotwordAlwaysOnSearchEnabled,
and I like the consistency of having the function name match the pref name. Let
me know if you feel strongly about this.

[rpetterson, 2014/09/12 03:03:32]

We only use SetEnabled for the pref call kHotwordSearchEnabled :) But I do not
feel strongly. It just seemed rather long and I was offering a suggestion.

[kcarattini, 2014/09/12 05:17:56]

Acknowledged.

+    : public ChromeSyncExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION("hotwordPrivate.setHotwordAlwaysOnSearchEnabled",
+                             HOTWORDPRIVATE_SETHOTWORDALWAYSONSEARCHENABLED)
+
+ protected:
+  virtual ~HotwordPrivateSetHotwordAlwaysOnSearchEnabledFunction() {}
+
+  // ExtensionFunction:
+  virtual bool RunSync() OVERRIDE;
+};
+
 class HotwordPrivateGetStatusFunction : public ChromeSyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("hotwordPrivate.getStatus",
                              HOTWORDPRIVATE_GETSTATUS)
 
  protected:
   virtual ~HotwordPrivateGetStatusFunction() {}
 
   // ExtensionFunction:
   virtual bool RunSync() OVERRIDE;
@@ skipping 34 matching lines @@
  protected:
   virtual ~HotwordPrivateGetLaunchStateFunction() {}
 
   // ExtensionFunction:
   virtual bool RunSync() OVERRIDE;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_HOTWORD_PRIVATE_HOTWORD_PRIVATE_API_H_