components/bookmarks/browser/bookmark_utils_unittest.cc - Issue 558913003: Remove clipboard argument from ScopedClipboardWriter constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_utils_unittest.cc

Issue 558913003: Remove clipboard argument from ScopedClipboardWriter constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't leak a clipboard on Windows Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/browser/bookmark_node_data.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_utils_unittest.cc

diff --git a/components/bookmarks/browser/bookmark_utils_unittest.cc b/components/bookmarks/browser/bookmark_utils_unittest.cc

index 61711d2456c3049ac01960fcf7fc4c57c55abc16..be6aef6e9c6f4f7afb0cb58477dd1f05036c4a45 100644

--- a/components/bookmarks/browser/bookmark_utils_unittest.cc

+++ b/components/bookmarks/browser/bookmark_utils_unittest.cc

@@ -266,8 +266,7 @@ TEST_F(BookmarkUtilsTest, PasteBookmarkFromURL) {

// Write blank text to clipboard.

{

- ui::ScopedClipboardWriter clipboard_writer(

- ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);

+ ui::ScopedClipboardWriter clipboard_writer(ui::CLIPBOARD_TYPE_COPY_PASTE);

clipboard_writer.WriteText(base::string16());

}

// Now we shouldn't be able to paste from the clipboard.

@@ -275,8 +274,7 @@ TEST_F(BookmarkUtilsTest, PasteBookmarkFromURL) {

// Write some valid url to the clipboard.

{

- ui::ScopedClipboardWriter clipboard_writer(

- ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);

+ ui::ScopedClipboardWriter clipboard_writer(ui::CLIPBOARD_TYPE_COPY_PASTE);

clipboard_writer.WriteText(url_text);

}

// Now we should be able to paste from the clipboard.

@@ -308,7 +306,6 @@ TEST_F(BookmarkUtilsTest, CopyPaste) {

// Write some text to the clipboard.

{

ui::ScopedClipboardWriter clipboard_writer(

- ui::Clipboard::GetForCurrentThread(),

ui::CLIPBOARD_TYPE_COPY_PASTE);

clipboard_writer.WriteText(ASCIIToUTF16("foo"));

}