Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: components/bookmarks/browser/bookmark_utils_unittest.cc

Issue 558913003: Remove clipboard argument from ScopedClipboardWriter constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't leak a clipboard on Windows Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/bookmarks/browser/bookmark_utils.h" 5 #include "components/bookmarks/browser/bookmark_utils.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 #if !defined(OS_IOS) 259 #if !defined(OS_IOS)
260 TEST_F(BookmarkUtilsTest, PasteBookmarkFromURL) { 260 TEST_F(BookmarkUtilsTest, PasteBookmarkFromURL) {
261 TestBookmarkClient client; 261 TestBookmarkClient client;
262 scoped_ptr<BookmarkModel> model(client.CreateModel()); 262 scoped_ptr<BookmarkModel> model(client.CreateModel());
263 const base::string16 url_text = ASCIIToUTF16("http://www.google.com/"); 263 const base::string16 url_text = ASCIIToUTF16("http://www.google.com/");
264 const BookmarkNode* new_folder = model->AddFolder( 264 const BookmarkNode* new_folder = model->AddFolder(
265 model->bookmark_bar_node(), 0, ASCIIToUTF16("New_Folder")); 265 model->bookmark_bar_node(), 0, ASCIIToUTF16("New_Folder"));
266 266
267 // Write blank text to clipboard. 267 // Write blank text to clipboard.
268 { 268 {
269 ui::ScopedClipboardWriter clipboard_writer( 269 ui::ScopedClipboardWriter clipboard_writer(ui::CLIPBOARD_TYPE_COPY_PASTE);
270 ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);
271 clipboard_writer.WriteText(base::string16()); 270 clipboard_writer.WriteText(base::string16());
272 } 271 }
273 // Now we shouldn't be able to paste from the clipboard. 272 // Now we shouldn't be able to paste from the clipboard.
274 EXPECT_FALSE(CanPasteFromClipboard(model.get(), new_folder)); 273 EXPECT_FALSE(CanPasteFromClipboard(model.get(), new_folder));
275 274
276 // Write some valid url to the clipboard. 275 // Write some valid url to the clipboard.
277 { 276 {
278 ui::ScopedClipboardWriter clipboard_writer( 277 ui::ScopedClipboardWriter clipboard_writer(ui::CLIPBOARD_TYPE_COPY_PASTE);
279 ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);
280 clipboard_writer.WriteText(url_text); 278 clipboard_writer.WriteText(url_text);
281 } 279 }
282 // Now we should be able to paste from the clipboard. 280 // Now we should be able to paste from the clipboard.
283 EXPECT_TRUE(CanPasteFromClipboard(model.get(), new_folder)); 281 EXPECT_TRUE(CanPasteFromClipboard(model.get(), new_folder));
284 282
285 PasteFromClipboard(model.get(), new_folder, 0); 283 PasteFromClipboard(model.get(), new_folder, 0);
286 ASSERT_EQ(1, new_folder->child_count()); 284 ASSERT_EQ(1, new_folder->child_count());
287 285
288 // Url for added node should be same as url_text. 286 // Url for added node should be same as url_text.
289 EXPECT_EQ(url_text, ASCIIToUTF16(new_folder->GetChild(0)->url().spec())); 287 EXPECT_EQ(url_text, ASCIIToUTF16(new_folder->GetChild(0)->url().spec()));
(...skipping 11 matching lines...) Expand all
301 std::vector<const BookmarkNode*> nodes; 299 std::vector<const BookmarkNode*> nodes;
302 nodes.push_back(node); 300 nodes.push_back(node);
303 CopyToClipboard(model.get(), nodes, false); 301 CopyToClipboard(model.get(), nodes, false);
304 302
305 // And make sure we can paste a bookmark from the clipboard. 303 // And make sure we can paste a bookmark from the clipboard.
306 EXPECT_TRUE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node())); 304 EXPECT_TRUE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node()));
307 305
308 // Write some text to the clipboard. 306 // Write some text to the clipboard.
309 { 307 {
310 ui::ScopedClipboardWriter clipboard_writer( 308 ui::ScopedClipboardWriter clipboard_writer(
311 ui::Clipboard::GetForCurrentThread(),
312 ui::CLIPBOARD_TYPE_COPY_PASTE); 309 ui::CLIPBOARD_TYPE_COPY_PASTE);
313 clipboard_writer.WriteText(ASCIIToUTF16("foo")); 310 clipboard_writer.WriteText(ASCIIToUTF16("foo"));
314 } 311 }
315 312
316 // Now we shouldn't be able to paste from the clipboard. 313 // Now we shouldn't be able to paste from the clipboard.
317 EXPECT_FALSE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node())); 314 EXPECT_FALSE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node()));
318 } 315 }
319 316
320 TEST_F(BookmarkUtilsTest, CopyPasteMetaInfo) { 317 TEST_F(BookmarkUtilsTest, CopyPasteMetaInfo) {
321 TestBookmarkClient client; 318 TestBookmarkClient client;
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 model->GetNodesByURL(url, &nodes); 517 model->GetNodesByURL(url, &nodes);
521 ASSERT_EQ(1u, nodes.size()); 518 ASSERT_EQ(1u, nodes.size());
522 EXPECT_TRUE(model->bookmark_bar_node()->empty()); 519 EXPECT_TRUE(model->bookmark_bar_node()->empty());
523 EXPECT_TRUE(model->other_node()->empty()); 520 EXPECT_TRUE(model->other_node()->empty());
524 EXPECT_TRUE(model->mobile_node()->empty()); 521 EXPECT_TRUE(model->mobile_node()->empty());
525 EXPECT_EQ(1, extra_node->child_count()); 522 EXPECT_EQ(1, extra_node->child_count());
526 } 523 }
527 524
528 } // namespace 525 } // namespace
529 } // namespace bookmarks 526 } // namespace bookmarks
OLDNEW
« no previous file with comments | « components/bookmarks/browser/bookmark_node_data.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698