Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 558813003: Disable scrolling for fullscreen elements by changing scroll layer size. (Closed)

Created:
6 years, 3 months ago by aelias_OOO_until_Jul13
Modified:
6 years, 3 months ago
Reviewers:
esprehn
CC:
blink-layers+watch_chromium.org, blink-reviews, kenneth.christiansen, qinmin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Disable scrolling for fullscreen elements by changing scroll layer size. After https://codereview.chromium.org/476113004 CC depends on the tree structure of scroll/clip layers to determine the viewport size, so detaching them breaks fullscreen mode. Switch to the other approach of changing the scroll layer bounds. BUG=410452 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aelias_OOO_until_Jul13
PTAL. This changes back to the other approach originally considered in https://codereview.chromium.org/200943002 because detaching the ...
6 years, 3 months ago (2014-09-09 22:04:15 UTC) #2
aelias_OOO_until_Jul13
esprehn@ -- nag for review because this came up as a potential dev blocker (this ...
6 years, 3 months ago (2014-09-11 03:50:11 UTC) #3
esprehn
lgtm
6 years, 3 months ago (2014-09-12 18:14:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558813003/1
6 years, 3 months ago (2014-09-12 18:19:21 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:40:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181926

Powered by Google App Engine
This is Rietveld 408576698