Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1986)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 558813003: Disable scrolling for fullscreen elements by changing scroll layer size. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/scrolling/ScrollingCoordinator.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index 264c4f204e40c854e67ce2b38e4f3701ae980905..01876cb49cc943022174da5d1e18b51145ea816f 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -5692,17 +5692,17 @@ TEST_F(WebFrameTest, FullscreenLayerNonScrollable)
webViewImpl->didEnterFullScreen();
webViewImpl->layout();
- // Verify that the main frame is not scrollable.
+ // Verify that the main frame bounds are empty.
ASSERT_TRUE(Fullscreen::isFullScreen(*document));
WebLayer* webScrollLayer = webViewImpl->compositor()->scrollLayer()->platformLayer();
- ASSERT_FALSE(webScrollLayer->scrollable());
+ ASSERT_EQ(WebSize(), webScrollLayer->bounds());
// Verify that the main frame is scrollable upon exiting fullscreen.
webViewImpl->didExitFullScreen();
webViewImpl->layout();
ASSERT_FALSE(Fullscreen::isFullScreen(*document));
webScrollLayer = webViewImpl->compositor()->scrollLayer()->platformLayer();
- ASSERT_TRUE(webScrollLayer->scrollable());
+ ASSERT_NE(WebSize(), webScrollLayer->bounds());
}
TEST_F(WebFrameTest, FullscreenMainFrameScrollable)
« no previous file with comments | « Source/core/page/scrolling/ScrollingCoordinator.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698