Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 558783005: remove label for= usage in keyboard overlay (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove label for= usage in keyboard overlay BUG=409938 Committed: https://crrev.com/2fb10c86ea720c678cbdd88894b6e8299c869f53 Cr-Commit-Position: refs/heads/master@{#294472}

Patch Set 1 #

Patch Set 2 : s/label/span #

Patch Set 3 : yay audit #

Patch Set 4 : add missing close tag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -43 lines) Patch
M chrome/browser/resources/options/chromeos/keyboard_overlay.html View 1 2 3 1 chunk +40 lines, -43 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Evan Stade
6 years, 3 months ago (2014-09-09 23:15:59 UTC) #2
dmazzoni
lgtm
6 years, 3 months ago (2014-09-09 23:36:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/558783005/20001
6 years, 3 months ago (2014-09-10 18:10:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/12822)
6 years, 3 months ago (2014-09-10 19:38:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558783005/40001
6 years, 3 months ago (2014-09-11 18:09:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/13307)
6 years, 3 months ago (2014-09-11 19:24:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558783005/60001
6 years, 3 months ago (2014-09-11 20:30:46 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as fcd2ab4fd4b614b8726dd3ef2ddc61092750877e
6 years, 3 months ago (2014-09-11 21:44:41 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 22:00:00 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/2fb10c86ea720c678cbdd88894b6e8299c869f53
Cr-Commit-Position: refs/heads/master@{#294472}

Powered by Google App Engine
This is Rietveld 408576698