Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: chrome/browser/resources/options/chromeos/keyboard_overlay.html

Issue 558783005: remove label for= usage in keyboard overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missing close tag Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <div id="keyboard-overlay" class="page" hidden> 1 <div id="keyboard-overlay" class="page" hidden>
2 <div class="close-button"></div> 2 <div class="close-button"></div>
3 <h1 i18n-content="keyboardOverlay"></h1> 3 <h1 i18n-content="keyboardOverlay"></h1>
4 <div class="content-area"> 4 <div class="content-area">
5 <table class="option-control-table"> 5 <table class="option-control-table">
6 <tr> 6 <tr>
7 <td> 7 <td class="option-name" id="remap-search-key-to-label"
8 <label class="option-name" for="remap-search-key-to" 8 i18n-content="remapSearchKeyToContent">
9 i18n-content="remapSearchKeyToContent">
10 </label>
11 </td> 9 </td>
12 <td class="option-value"> 10 <td class="option-value">
13 <select id="remap-search-key-to" class="control" 11 <select class="control"
14 data-type="number" i18n-options="remapSearchKeyToValue" 12 data-type="number" i18n-options="remapSearchKeyToValue"
15 metric="Options_KeyboardRemapSearchKey" 13 metric="Options_KeyboardRemapSearchKey"
16 pref="settings.language.xkb_remap_search_key_to" dialog-pref> 14 pref="settings.language.xkb_remap_search_key_to"
15 aria-labelledby="remap-search-key-to-label" dialog-pref>
17 </select> 16 </select>
18 </td> 17 </td>
19 </tr> 18 </tr>
20 <tr> 19 <tr>
21 <td> 20 <td class="option-name" id="remap-control-key-to-label"
22 <label class="option-name" for="remap-control-key-to" 21 i18n-content="remapControlKeyToContent">
23 i18n-content="remapControlKeyToContent">
24 </label>
25 </td> 22 </td>
26 <td class="option-value"> 23 <td class="option-value">
27 <select id="remap-control-key-to" class="control" 24 <select class="control"
28 data-type="number" i18n-options="remapControlKeyToValue" 25 data-type="number" i18n-options="remapControlKeyToValue"
29 metric="Options_KeyboardRemapControlKey" 26 metric="Options_KeyboardRemapControlKey"
30 pref="settings.language.xkb_remap_control_key_to" dialog-pref> 27 pref="settings.language.xkb_remap_control_key_to"
28 aria-labelledby="remap-control-key-to-label" dialog-pref>
31 </select> 29 </select>
32 </td> 30 </td>
33 </tr> 31 </tr>
34 <tr> 32 <tr>
35 <td> 33 <td class="option-name" id="remap-alt-key-to-label"
36 <label class="option-name" for="remap-alt-key-to" 34 i18n-content="remapAltKeyToContent">
37 i18n-content="remapAltKeyToContent">
38 </label>
39 </td> 35 </td>
40 <td class="option-value"> 36 <td class="option-value">
41 <select id="remap-alt-key-to" class="control" data-type="number" 37 <select class="control" data-type="number"
42 metric="Options_KeyboardRemapAltKey" 38 metric="Options_KeyboardRemapAltKey"
43 pref="settings.language.xkb_remap_alt_key_to" 39 pref="settings.language.xkb_remap_alt_key_to"
44 i18n-options="remapAltKeyToValue" dialog-pref></select> 40 i18n-options="remapAltKeyToValue"
41 aria-labelledby="remap-alt-key-to-label" dialog-pref></select>
45 </td> 42 </td>
46 </tr> 43 </tr>
47 <!-- The caps lock section is hidden by default. This is only visible 44 <!-- The caps lock section is hidden by default. This is only visible
48 when --has-chromeos-keyboard flag is not passed. --> 45 when --has-chromeos-keyboard flag is not passed. -->
49 <tr id="caps-lock-remapping-section" hidden> 46 <tr id="caps-lock-remapping-section" hidden>
50 <td> 47 <td class="option-name" id="remap-caps-lock-key-to-label"
51 <label class="option-name" for="remap-caps-lock-key-to"
52 i18n-content="remapCapsLockKeyToContent"> 48 i18n-content="remapCapsLockKeyToContent">
53 </label>
54 </td> 49 </td>
55 <td class="option-value"> 50 <td class="option-value">
56 <select id="remap-caps-lock-key-to" class="control" 51 <select class="control"
57 data-type="number" 52 data-type="number"
58 metric="Options_KeyboardRemapCapsLockKey" 53 metric="Options_KeyboardRemapCapsLockKey"
59 pref="settings.language.remap_caps_lock_key_to" 54 pref="settings.language.remap_caps_lock_key_to"
60 i18n-options="remapCapsLockKeyToValue" dialog-pref></select> 55 aria-labelledby="remap-caps-lock-key-to-label" dialog-pref>
56 </select>
61 </td> 57 </td>
62 </tr> 58 </tr>
63 <!-- The diamond key section is hidden by default. This is only visible 59 <!-- The diamond key section is hidden by default. This is only visible
64 when --has-chromeos-diamond-key flag is passed. --> 60 when --has-chromeos-diamond-key flag is passed. -->
65 <tr id="diamond-key-remapping-section" hidden> 61 <tr id="diamond-key-remapping-section" hidden>
66 <td> 62 <td class="option-name" id="remap-diamond-key-to-label"
67 <label class="option-name" for="remap-diamond-key-to" 63 i18n-content="remapDiamondKeyToContent">
68 i18n-content="remapDiamondKeyToContent">
69 </label>
70 </td> 64 </td>
71 <td class="option-value"> 65 <td class="option-value">
72 <select id="remap-diamond-key-to" class="control" 66 <select class="control"
73 data-type="number" 67 data-type="number"
74 metric="Options_KeyboardRemapDiamondKey" 68 metric="Options_KeyboardRemapDiamondKey"
75 pref="settings.language.remap_diamond_key_to" 69 pref="settings.language.remap_diamond_key_to"
76 i18n-options="remapDiamondKeyToValue" dialog-pref></select> 70 i18n-options="remapDiamondKeyToValue"
71 aria-labelledby="remap-diamond-key-to-label" dialog-pref>
72 </select>
77 </td> 73 </td>
78 </tr> 74 </tr>
79 </table> 75 </table>
80 <div class="settings-row"> 76 <div class="settings-row">
81 <div class="checkbox"> 77 <div class="checkbox controlled-setting-with-label">
82 <span class="controlled-setting-with-label"> 78 <label>
83 <input id="send-function-keys" type="checkbox" 79 <input type="checkbox"
84 pref="settings.language.send_function_keys" dialog-pref> 80 pref="settings.language.send_function_keys"
81 aria-describedby="send-function-keys-description" dialog-pref>
85 <span> 82 <span>
86 <label for="send-function-keys" i18n-content="sendFunctionKeys"> 83 <span i18n-content="sendFunctionKeys"></span>
87 </label>
88 <span class="bubble-button controlled-setting-indicator" 84 <span class="bubble-button controlled-setting-indicator"
89 pref="settings.language.send_function_keys"></span> 85 pref="settings.language.send_function_keys"></span>
90 </span> 86 </span>
91 </span> 87 </label>
92 </div> 88 </div>
93 <label id="send-function-keys-description" for="send-function-keys" 89 <span id="send-function-keys-description"
94 i18n-content="sendFunctionKeysDescription"> 90 i18n-content="sendFunctionKeysDescription"></span>
95 </label>
96 </div> 91 </div>
97 <div class="settings-row"> 92 <div class="settings-row">
98 <div class="checkbox"> 93 <div class="checkbox">
99 <input id="enable-auto-repeat" type="checkbox" 94 <label>
100 pref="settings.language.xkb_auto_repeat_enabled_r2" 95 <input id="enable-auto-repeat" type="checkbox"
101 metric="Options_KeyboardAutoRepeat" dialog-pref> 96 pref="settings.language.xkb_auto_repeat_enabled_r2"
102 <label for="enable-auto-repeat" i18n-content="enableAutoRepeat"></label> 97 metric="Options_KeyboardAutoRepeat" dialog-pref>
98 <span i18n-content="enableAutoRepeat"></span>
99 </label>
103 </div> 100 </div>
104 <div id="auto-repeat-settings-section"> 101 <div id="auto-repeat-settings-section">
105 <div class="row"> 102 <div class="row">
106 <span class="option-name" i18n-content="autoRepeatDelay"></span> 103 <span class="option-name" i18n-content="autoRepeatDelay"></span>
107 <span i18n-content="autoRepeatDelayLong"></span> 104 <span i18n-content="autoRepeatDelayLong"></span>
108 <input id="auto-repeat-delay-range" type="range" 105 <input id="auto-repeat-delay-range" type="range"
109 class="touch-slider" 106 class="touch-slider"
110 pref="settings.language.xkb_auto_repeat_delay_r2" dialog-pref> 107 pref="settings.language.xkb_auto_repeat_delay_r2" dialog-pref>
111 <span i18n-content="autoRepeatDelayShort"></span> 108 <span i18n-content="autoRepeatDelayShort"></span>
112 </div> 109 </div>
(...skipping 15 matching lines...) Expand all
128 </div> 125 </div>
129 <div class="action-area"> 126 <div class="action-area">
130 <div class="button-strip"> 127 <div class="button-strip">
131 <button id="keyboard-cancel" type="reset" i18n-content="cancel"></button> 128 <button id="keyboard-cancel" type="reset" i18n-content="cancel"></button>
132 <button id="keyboard-confirm" class="default-button" type="submit" 129 <button id="keyboard-confirm" class="default-button" type="submit"
133 i18n-content="ok"> 130 i18n-content="ok">
134 </button> 131 </button>
135 </div> 132 </div>
136 </div> 133 </div>
137 </div> 134 </div>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698