Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 558763002: Require build directories exist for some GN commands. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Require build directories exist for some GN commands. Some GN commands just query the state of the build. They generally take the build directory as a first argument. But this is easy to forget and GN will auto-create these directories if they don't exist. So I end up with directories named "base/*" because I was trying to list all targets in base but forgot the build argument. This patch requires that the build directory contain a build.ninja file for the "querying" commands to prevent this case. Committed: https://crrev.com/4dd3ef06036b5b7bfc430ee4a5013856cfe8d872 Cr-Commit-Position: refs/heads/master@{#294071}

Patch Set 1 #

Patch Set 2 : file path literal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M tools/gn/command_args.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/command_check.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_desc.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_ls.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_refs.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/setup.h View 2 chunks +10 lines, -3 lines 0 comments Download
M tools/gn/setup.cc View 1 4 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
6 years, 3 months ago (2014-09-09 20:24:24 UTC) #2
jamesr
lgtm. i've had the same thing
6 years, 3 months ago (2014-09-09 20:46:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/558763002/1
6 years, 3 months ago (2014-09-09 20:58:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/9341) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg/builds/13869) win_chromium_rel_swarming ...
6 years, 3 months ago (2014-09-09 22:05:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/558763002/20001
6 years, 3 months ago (2014-09-09 23:25:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 049db789e25edf2f4a23f43d9f7d9018db0602a2
6 years, 3 months ago (2014-09-10 01:46:54 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:57:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4dd3ef06036b5b7bfc430ee4a5013856cfe8d872
Cr-Commit-Position: refs/heads/master@{#294071}

Powered by Google App Engine
This is Rietveld 408576698