tools/gn/command_gen.cc - Issue 558763002: Require build directories exist for some GN commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_gen.cc

Issue 558763002: Require build directories exist for some GN commands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: file path literal Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/command_gen.cc

diff --git a/tools/gn/command_gen.cc b/tools/gn/command_gen.cc

index 5e6e724852af054f0be1f11ef6d0ee8e75a1249a..6ce87a5ac43bbe6e595f4b8577be1e9f31381da5 100644

--- a/tools/gn/command_gen.cc

+++ b/tools/gn/command_gen.cc

@@ -77,7 +77,7 @@ int RunGen(const std::vector<std::string>& args) {

// Deliberately leaked to avoid expensive process teardown.

Setup* setup = new Setup();

- if (!setup->DoSetup(args[0]))

+ if (!setup->DoSetup(args[0], true))

return 1;

if (CommandLine::ForCurrentProcess()->HasSwitch(kSwitchCheck))

« no previous file with comments | « tools/gn/command_desc.cc ('k') | tools/gn/command_ls.cc » ('j') | no next file with comments »