Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 558693002: Adjust error-handling for invalid filter primitive references (Closed)

Created:
6 years, 3 months ago by fs
Modified:
6 years, 3 months ago
CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Adjust error-handling for invalid filter primitive references When a filter primitive has an 'in' (or, where applicable, 'in2') attribute that references a non-existent result, treat that reference as having the default value (==no value) instead of producing an error. This aligns with Presto and IE. BUG=411833 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/svg/filters/in-attribute-error-handling.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/svg/filters/in-attribute-error-handling-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fs
6 years, 3 months ago (2014-09-10 07:24:06 UTC) #2
Stephen White
Code looks fine, but I'm wondering how to interpret the spec on this. The only ...
6 years, 3 months ago (2014-09-10 12:39:42 UTC) #3
fs
On 2014/09/10 12:39:42, Stephen White wrote: > Code looks fine, but I'm wondering how to ...
6 years, 3 months ago (2014-09-10 14:01:11 UTC) #4
Stephen White
On 2014/09/10 14:01:11, fs wrote: > On 2014/09/10 12:39:42, Stephen White wrote: > > Code ...
6 years, 3 months ago (2014-09-10 14:09:19 UTC) #5
fs
On 2014/09/10 14:09:19, Stephen White wrote: > On 2014/09/10 14:01:11, fs wrote: > > On ...
6 years, 3 months ago (2014-09-10 14:21:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/558693002/1
6 years, 3 months ago (2014-09-10 14:21:58 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 14:25:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181733

Powered by Google App Engine
This is Rietveld 408576698