Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: Source/core/svg/graphics/filters/SVGFilterBuilder.cpp

Issue 558693002: Adjust error-handling for invalid filter primitive references (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/filters/in-attribute-error-handling-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
diff --git a/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp b/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
index 876934856b0aa1e491e29b691a62e3869e298ce1..7a031b1ecbf72aac095afac131054cabc29441bc 100644
--- a/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
+++ b/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
@@ -48,17 +48,18 @@ void SVGFilterBuilder::add(const AtomicString& id, PassRefPtr<FilterEffect> effe
FilterEffect* SVGFilterBuilder::getEffectById(const AtomicString& id) const
{
- if (id.isEmpty()) {
- if (m_lastEffect)
- return m_lastEffect.get();
+ if (!id.isEmpty()) {
+ if (FilterEffect* builtinEffect = m_builtinEffects.get(id))
+ return builtinEffect;
- return m_builtinEffects.get(SourceGraphic::effectName());
+ if (FilterEffect* namedEffect = m_namedEffects.get(id))
+ return namedEffect;
}
- if (m_builtinEffects.contains(id))
- return m_builtinEffects.get(id);
+ if (m_lastEffect)
+ return m_lastEffect.get();
- return m_namedEffects.get(id);
+ return m_builtinEffects.get(SourceGraphic::effectName());
}
void SVGFilterBuilder::appendEffectToEffectReferences(PassRefPtr<FilterEffect> prpEffect, RenderObject* object)
« no previous file with comments | « LayoutTests/svg/filters/in-attribute-error-handling-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698