chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc - Issue 558603002: [SyncFS] Make MetadataDatabase operations synchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc

Issue 558603002: [SyncFS] Make MetadataDatabase operations synchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_create

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc ('K') | « chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc ('k') | chrome/browser/sync_file_system/drive_backend/metadata_database.h » ('j') | chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc b/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc

index 2f1e94e9e2e9381a0b1571a6c23dfbd8f0abe3da..63d5134161424dc96950a5cdf32b80380de8d015 100644

--- a/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc

+++ b/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc

@@ -121,10 +121,8 @@ class LocalToRemoteSyncerTest : public testing::Test {

void RegisterApp(const std::string& app_id,

const std::string& app_root_folder_id) {

- SyncStatusCode status = SYNC_STATUS_FAILED;

- context_->GetMetadataDatabase()->RegisterApp(

- app_id, app_root_folder_id, CreateResultReceiver(&status));

- base::RunLoop().RunUntilIdle();

+ SyncStatusCode status = context_->GetMetadataDatabase()->RegisterApp(

+ app_id, app_root_folder_id);

EXPECT_EQ(SYNC_STATUS_OK, status);

}