[SyncFS] Make MetadataDatabase operations synchronous

chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

Index: chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc b/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
index e8324b5da0f0976e6084c9ad77a1b0ee4b5fc353..1dd28e932385030b4e499832a45bbe6955d92487 100644
--- a/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
+++ b/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
@@ -315,8 +315,9 @@ void RemoteToLocalSyncer::DidGetRemoteMetadata(
   }
 
   if (error == google_apis::HTTP_NOT_FOUND) {
-    metadata_database()->UpdateByDeletedRemoteFile(
-        dirty_tracker_->file_id(), SyncCompletedCallback(token.Pass()));
+    status = metadata_database()->UpdateByDeletedRemoteFile(
+        dirty_tracker_->file_id());
+    SyncCompleted(token.Pass(), status);
     return;
   }
 
@@ -326,11 +327,8 @@ void RemoteToLocalSyncer::DidGetRemoteMetadata(
     return;
   }
 
-  metadata_database()->UpdateByFileResource(
-      *entry,
-      base::Bind(&RemoteToLocalSyncer::DidUpdateDatabaseForRemoteMetadata,
-                 weak_ptr_factory_.GetWeakPtr(),
-                 base::Passed(&token)));
+  status = metadata_database()->UpdateByFileResource(*entry);
+  DidUpdateDatabaseForRemoteMetadata(token.Pass(), status);

[peria, 2014/09/10 00:24:15]

Expand  DidUpdateDatabaseForRemoteMetadata() here

[tzik, 2014/09/10 00:56:54]

ditto

 }
 
 void RemoteToLocalSyncer::DidUpdateDatabaseForRemoteMetadata(
@@ -584,9 +582,9 @@ void RemoteToLocalSyncer::DidListFolderContent(
     return;
   }
 
-  metadata_database()->PopulateFolderByChildList(
-      dirty_tracker_->file_id(), *children,
-      SyncCompletedCallback(token.Pass()));
+  status = metadata_database()->PopulateFolderByChildList(
+      dirty_tracker_->file_id(), *children);
+  SyncCompleted(token.Pass(), status);
 }
 
 void RemoteToLocalSyncer::SyncCompleted(scoped_ptr<SyncTaskToken> token,
@@ -627,12 +625,10 @@ void RemoteToLocalSyncer::SyncCompleted(scoped_ptr<SyncTaskToken> token,
       updated_details.set_missing(true);
     }
   }
-  metadata_database()->UpdateTracker(
-      dirty_tracker_->tracker_id(),
-      updated_details,
-      base::Bind(&RemoteToLocalSyncer::FinalizeSync,
-                 weak_ptr_factory_.GetWeakPtr(),
-                 base::Passed(&token)));
+
+  status = metadata_database()->UpdateTracker(
+      dirty_tracker_->tracker_id(), updated_details);
+  FinalizeSync(token.Pass(), status);

[peria, 2014/09/10 00:24:15]

Expand FinalizeSync() here.

[tzik, 2014/09/10 00:56:54]

ditto

 }
 
 void RemoteToLocalSyncer::FinalizeSync(scoped_ptr<SyncTaskToken> token,