Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 55843002: Length type Relative is now unused. Remove it. (Closed)

Created:
7 years, 1 month ago by davve
Modified:
7 years, 1 month ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), zoltan1, eae+blinkwatch, dglazkov+blink, leviw+renderwatch, dstockwell, Timothy Loh, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@length-relative-die-step-3-4
Visibility:
Public.

Description

Length type Relative is now unused. Remove it. BUG=259107 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSLengthFunctions.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/Length.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/platform/LengthFunctions.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
davve
7 years, 1 month ago (2013-11-01 14:21:41 UTC) #1
Julien - ping for review
lgtm
7 years, 1 month ago (2013-11-04 18:31:09 UTC) #2
alancutter (OOO until 2018)
davve: This patch appears to be based ontop of another patch rather than Blink ToT ...
7 years, 1 month ago (2013-11-07 23:02:29 UTC) #3
davve
On 2013/11/07 23:02:29, alancutter wrote: > davve: This patch appears to be based ontop of ...
7 years, 1 month ago (2013-11-10 19:22:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/55843002/1
7 years, 1 month ago (2013-11-12 12:31:51 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 14:20:38 UTC) #6
Message was sent while issue was closed.
Change committed as 161809

Powered by Google App Engine
This is Rietveld 408576698