Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 55843002: Length type Relative is now unused. Remove it. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@length-relative-die-step-3-4
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSCalculationValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 case Intrinsic: 82 case Intrinsic:
83 case MinIntrinsic: 83 case MinIntrinsic:
84 case MinContent: 84 case MinContent:
85 case MaxContent: 85 case MaxContent:
86 case FillAvailable: 86 case FillAvailable:
87 case FitContent: 87 case FitContent:
88 return AnimatableUnknown::create(CSSPrimitiveValue::create(length)); 88 return AnimatableUnknown::create(CSSPrimitiveValue::create(length));
89 case Undefined: 89 case Undefined:
90 return AnimatableUnknown::create(CSSValueNone); 90 return AnimatableUnknown::create(CSSValueNone);
91 case ExtendToZoom: // Does not apply to elements. 91 case ExtendToZoom: // Does not apply to elements.
92 case Relative: // Does not get used by interpolable properties.
93 ASSERT_NOT_REACHED(); 92 ASSERT_NOT_REACHED();
94 return 0; 93 return 0;
95 } 94 }
96 ASSERT_NOT_REACHED(); 95 ASSERT_NOT_REACHED();
97 return 0; 96 return 0;
98 } 97 }
99 98
100 inline static PassRefPtr<AnimatableValue> createFromDouble(double value, Animata bleDouble::Constraint constraint = AnimatableDouble::Unconstrained) 99 inline static PassRefPtr<AnimatableValue> createFromDouble(double value, Animata bleDouble::Constraint constraint = AnimatableDouble::Unconstrained)
101 { 100 {
102 return AnimatableDouble::create(value, constraint); 101 return AnimatableDouble::create(value, constraint);
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 case CSSPropertyZoom: 441 case CSSPropertyZoom:
443 return createFromDouble(style->zoom()); 442 return createFromDouble(style->zoom());
444 default: 443 default:
445 RELEASE_ASSERT_WITH_MESSAGE(!CSSAnimations::isAnimatableProperty(propert y), "Web Animations not yet implemented: Create AnimatableValue from render styl e: %s", getPropertyNameString(property).utf8().data()); 444 RELEASE_ASSERT_WITH_MESSAGE(!CSSAnimations::isAnimatableProperty(propert y), "Web Animations not yet implemented: Create AnimatableValue from render styl e: %s", getPropertyNameString(property).utf8().data());
446 ASSERT_NOT_REACHED(); 445 ASSERT_NOT_REACHED();
447 return 0; 446 return 0;
448 } 447 }
449 } 448 }
450 449
451 } // namespace WebCore 450 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/CSSCalculationValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698