Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 55833002: Rewrite BorderImageLength to not use the Relative length type (Closed)

Created:
7 years, 1 month ago by davve
Modified:
7 years, 1 month ago
CC:
blink-reviews, Steve Block
Base URL:
https://chromium.googlesource.com/chromium/blink.git@length-relative-die-step-2-4
Visibility:
Public.

Description

Rewrite BorderImageLength to not use the Relative length type Remove the last remaining Relative length and instead store a Length _and_ a double value along with a type tag, a pattern also used by GridLength in the Flexbox code. While it increases memory usage slightly, getting rid of the Relative length type is deemed more important. BUG=259107 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161802

Patch Set 1 #

Patch Set 2 : Rebased on top of https://codereview.chromium.org/55813002/ #

Total comments: 2

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M Source/core/rendering/style/BorderImageLength.h View 1 2 1 chunk +20 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
davve
7 years, 1 month ago (2013-11-01 14:21:25 UTC) #1
Julien - ping for review
lgtm https://codereview.chromium.org/55833002/diff/40001/Source/platform/BorderImageLength.h File Source/platform/BorderImageLength.h (right): https://codereview.chromium.org/55833002/diff/40001/Source/platform/BorderImageLength.h#newcode40 Source/platform/BorderImageLength.h:40: // Default is 'auto' Default _Length_ is 'auto' ...
7 years, 1 month ago (2013-11-04 18:30:25 UTC) #2
davve
Depends on https://codereview.chromium.org/55813002/
7 years, 1 month ago (2013-11-10 19:21:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/55833002/100001
7 years, 1 month ago (2013-11-11 11:50:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/55833002/100001
7 years, 1 month ago (2013-11-12 11:37:23 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 12:22:31 UTC) #6
Message was sent while issue was closed.
Change committed as 161802

Powered by Google App Engine
This is Rietveld 408576698