Rewrite BorderImageLength to not use the Relative length type

Source/platform/BorderImageLength.h

 /*
  * Copyright (c) 2013, Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef BorderImageLength_h
 #define BorderImageLength_h
 
 #include "platform/Length.h"
 
 namespace WebCore {
 
 class PLATFORM_EXPORT BorderImageLength {
 public:
+    // Default is 'auto'

[Julien - ping for review, 2013/11/04 18:30:25]

Default _Length_ is 'auto' if that changed, this wouldn't hold. We can either
make it obvious by calling Length(Auto) (which would be my preference) or
referencing this Length constructor here.

     BorderImageLength()
+        : m_number(0)
+        , m_type(LengthType)
     {
     }
 
     BorderImageLength(double number)
-        : m_length(number, Relative)
+        : m_length(Undefined)
+        , m_number(number)
+        , m_type(NumberType)
     {
     }
 
     BorderImageLength(const Length& length)
         : m_length(length)
+        , m_number(0)
+        , m_type(LengthType)
     {
     }
 
-    bool isNumber() const { return m_length.isRelative(); }
-    bool isLength() const { return !isNumber(); }
+    bool isNumber() const { return m_type == NumberType; }
+    bool isLength() const { return m_type == LengthType; }
 
     const Length& length() const { ASSERT(isLength()); return m_length; }
     Length& length() { ASSERT(isLength()); return m_length; }
 
-    double number() const { ASSERT(isNumber()); return m_length.value(); }
+    double number() const { ASSERT(isNumber()); return m_number; }
 
     bool operator==(const BorderImageLength& o) const
     {
-        return m_length == o.m_length;
+        return m_length == o.m_length && m_number == o.m_number && m_type == o.m_type;

[Julien - ping for review, 2013/11/04 18:30:25]

Nit: Let's put m_type first. And |o| -> |other| ^_^

     }
 
     bool isZero() const
     {
-        return m_length.isZero();
+        return (isLength() && m_length.isZero()) || (isNumber() && m_number);
     }
 
 private:
+    // Ideally we would put the 2 following fields in a union, but Length has a constructor,
+    // a destructor and a copy assignment which isn't allowed.
     Length m_length;
+    double m_number;
+    enum {
+        LengthType,
+        NumberType
+    } m_type;
 };
 
 } // namespace WebCore
 
 #endif // BorderImageLength_h