Issue 558233002: Clean up security_wrappers.cc/.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 558233002: Clean up security_wrappers.cc/.h (Closed)

Created:
6 years, 3 months ago by Jiang Jiang

Modified:
6 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Clean up security_wrappers.cc/.h It was introduced by https://codereview.chromium.org/10344009 for keychain reauthorization, now that keychain reauthorization was removed by https://codereview.chromium.org/183713003 we no longer need most of it. BUG=411926 Committed: https://crrev.com/a80fc361793678a90258e50aa1c9f697c7df64e0 Cr-Commit-Position: refs/heads/master@{#294187}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -582 lines)			Patch
	M	chrome/browser/mac/security_wrappers.h	View		2 chunks	+2 lines, -205 lines	0 comments	Download
	M	chrome/browser/mac/security_wrappers.cc	View		2 chunks	+2 lines, -377 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/558233002/1

6 years, 3 months ago (2014-09-10 16:52:55 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 8db961c7cbec9bed23d4369f99426c75062d4dd4

6 years, 3 months ago (2014-09-10 17:54:36 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 18:06:08 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a80fc361793678a90258e50aa1c9f697c7df64e0
Cr-Commit-Position: refs/heads/master@{#294187}