Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 183713003: Remove keychain_reauthorize (Closed)

Created:
6 years, 9 months ago by Mark Mentovai
Modified:
6 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Remove keychain_reauthorize. This code was used when we changed our signing certificate. By now, all Keychain entries have been migrated to the new certificate. If we ever need this again, we can resurrect it from version control history. BUG=347622 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254132

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -733 lines) Patch
M chrome/browser/chrome_browser_main_mac.mm View 3 chunks +0 lines, -31 lines 0 comments Download
D chrome/browser/mac/keychain_reauthorize.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/mac/keychain_reauthorize.mm View 1 chunk +0 lines, -526 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/mac/dmgdiffer.sh View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/installer/mac/keystone_install.sh View 2 chunks +0 lines, -46 lines 0 comments Download
D chrome/tools/build/mac/copy_keychain_reauthorize.sh View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
6 years, 9 months ago (2014-02-27 19:53:16 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-02-27 22:40:12 UTC) #2
Mark Mentovai
6 years, 9 months ago (2014-02-28 15:42:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r254132 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698