Issue 5581002: Merge 67883 - Listen for APP_TERMINATING in notification ui; close windows ea...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5581002: Merge 67883 - Listen for APP_TERMINATING in notification ui; close windows ea... (Closed)

Created:
10 years ago by Cris Neckar

Modified:
9 years, 7 months ago

Reviewers:
John Gregg

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/597/src/

Visibility:
Public.

Merge 67883 - Listen for APP_TERMINATING in notification ui; close windows earlier in the process before they get clobbered by browser_shutdown leading to a potential double-close. BUG=58053 TEST=exit chrome with notifications open Review URL: http://codereview.chromium.org/5319011 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68035

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -1 line)			Patch
M	chrome/browser/chromeos/notifications/balloon_collection_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/notifications/balloon_collection_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_base.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_base.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/notifications/notification_ui_manager.h	View	4 chunks	+16 lines, -1 line	0 comments	Download
M	chrome/browser/notifications/notification_ui_manager.cc	View	4 chunks	+18 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)