Issue 5319011: Listen for APP_TERMINATING in notification ui; close windows earlier in the p...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5319011: Listen for APP_TERMINATING in notification ui; close windows earlier in the p... (Closed)

Created:
10 years ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Listen for APP_TERMINATING in notification ui; close windows earlier in the process before they get clobbered by browser_shutdown leading to a potential double-close. BUG=58053 TEST=exit chrome with notifications open Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67883

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -1 line)			Patch
M	chrome/browser/chromeos/notifications/balloon_collection_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/notifications/balloon_collection_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/notifications/balloon_controller_unittest.mm	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_base.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_base.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/notifications/notification_ui_manager.h	View		4 chunks	+16 lines, -1 line	0 comments	Download
M	chrome/browser/notifications/notification_ui_manager.cc	View		4 chunks	+18 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

10 years ago (2010-12-01 01:55:56 UTC) #2

LGTM

http://codereview.chromium.org/5319011/diff/12001/chrome/browser/notification...
File chrome/browser/notifications/notification_ui_manager.cc (right):

http://codereview.chromium.org/5319011/diff/12001/chrome/browser/notification...
chrome/browser/notifications/notification_ui_manager.cc:93: iter =
show_queue_.erase(iter);
You are tracking this separately, but just wanted to point out that we're
leaking a QueuedNotification here.

http://codereview.chromium.org/5319011/diff/12001/chrome/browser/notification...
chrome/browser/notifications/notification_ui_manager.cc:164: CancelAll();
Could also be CHECK(type == NotificationType::APP_TERMINATING). But this is cool
too.

Expand Messages | Collapse Messages