Issue 557933002: List Subzero's local optlevel flags after LLVM's cxxflags (precedence).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 557933002: List Subzero's local optlevel flags after LLVM's cxxflags (precedence). (Closed)

Created:
6 years, 3 months ago by jvoung (off chromium)

Modified:
6 years, 3 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

List Subzero's local optlevel flags after LLVM's cxxflags (precedence). Ended up needing to fix the InstX8632Lockable error that JF ran into now that -O0 is really -O0: https://codereview.chromium.org/512933006/ BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a262333e7339a33df4863a521a7ae71cb18bb138

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	Makefile.standalone	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/IceInstX8632.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

jvoung (off chromium)

6 years, 3 months ago (2014-09-09 23:36:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as a262333 (tree was closed).