Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8179)

Unified Diff: chrome/browser/upgrade_detector_impl.h

Issue 557833006: Fix WeakPtrFactory member ordering in chrome/browser and chrome/service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the WeakPtr comments in files Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/upgrade_detector_impl.h
diff --git a/chrome/browser/upgrade_detector_impl.h b/chrome/browser/upgrade_detector_impl.h
index 63b05e8407b7018addcc047c65eab9ea0a55ad17..90abe05c07c4ed8eadaa66e5af2b06bbd68dae2e 100644
--- a/chrome/browser/upgrade_detector_impl.h
+++ b/chrome/browser/upgrade_detector_impl.h
@@ -79,11 +79,6 @@ class UpgradeDetectorImpl :
// has passed and we should start notifying the user.
base::RepeatingTimer<UpgradeDetectorImpl> upgrade_notification_timer_;
- // We use this factory to create callback tasks for UpgradeDetected. We pass
- // the task to the actual upgrade detection code, which is in
- // DetectUpgradeTask.
- base::WeakPtrFactory<UpgradeDetectorImpl> weak_factory_;
-
// True if this build is a dev or canary channel build.
bool is_unstable_channel_;
@@ -97,6 +92,11 @@ class UpgradeDetectorImpl :
// The date the binaries were built.
base::Time build_date_;
+ // We use this factory to create callback tasks for UpgradeDetected. We pass
+ // the task to the actual upgrade detection code, which is in
+ // DetectUpgradeTask.
+ base::WeakPtrFactory<UpgradeDetectorImpl> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(UpgradeDetectorImpl);
};
« no previous file with comments | « chrome/browser/sync/sessions/notification_service_sessions_router.h ('k') | chrome/browser/upgrade_detector_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698