Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: chrome/browser/upgrade_detector_impl.cc

Issue 557833006: Fix WeakPtrFactory member ordering in chrome/browser and chrome/service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the WeakPtr comments in files Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/upgrade_detector_impl.h ('k') | chrome/service/cloud_print/printer_job_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/upgrade_detector_impl.cc
diff --git a/chrome/browser/upgrade_detector_impl.cc b/chrome/browser/upgrade_detector_impl.cc
index 7ce3eb03833f30398e701a4260bc8946279622da..e61d2f86e2fc3d2dd3420c28726fdcb3ac5ce810 100644
--- a/chrome/browser/upgrade_detector_impl.cc
+++ b/chrome/browser/upgrade_detector_impl.cc
@@ -187,10 +187,10 @@ base::Version GetCurrentlyInstalledVersionImpl(Version* critical_update) {
} // namespace
UpgradeDetectorImpl::UpgradeDetectorImpl()
- : weak_factory_(this),
- is_unstable_channel_(false),
+ : is_unstable_channel_(false),
is_auto_update_enabled_(true),
- build_date_(base::GetBuildTime()) {
+ build_date_(base::GetBuildTime()),
+ weak_factory_(this) {
CommandLine command_line(*CommandLine::ForCurrentProcess());
// The different command line switches that affect testing can't be used
// simultaneously, if they do, here's the precedence order, based on the order
« no previous file with comments | « chrome/browser/upgrade_detector_impl.h ('k') | chrome/service/cloud_print/printer_job_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698