Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 557663002: Restored printing windows context for builds without preview. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
Reviewers:
Noam Samuel, Marshall
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Restored printing windows context for builds without preview. This is code placed into separate file that was removed in https://codereview.chromium.org/478183005 Code is still used by CEF. BUG=374321 NOTRY=true Committed: https://crrev.com/f9d0c0ca61adcc78669177583c701607d70cdb0f Cr-Commit-Position: refs/heads/master@{#293992}

Patch Set 1 #

Patch Set 2 : Mon Sep 8 23:36:56 PDT 2014 #

Total comments: 2

Patch Set 3 : Tue Sep 9 12:14:54 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -35 lines) Patch
M printing/printing.gyp View 3 chunks +5 lines, -3 lines 0 comments Download
A printing/printing_context_system_dialog_win.h View 1 chunk +56 lines, -0 lines 0 comments Download
A printing/printing_context_system_dialog_win.cc View 1 1 chunk +269 lines, -0 lines 0 comments Download
M printing/printing_context_win.h View 1 2 chunks +14 lines, -10 lines 0 comments Download
M printing/printing_context_win.cc View 1 2 3 chunks +23 lines, -21 lines 0 comments Download
M printing/printing_context_win_unittest.cc View 2 chunks +140 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Vitaly Buka (NO REVIEWS)
Please review.
6 years, 3 months ago (2014-09-09 06:41:26 UTC) #2
Marshall
Tested to work with CEF. See comments on https://codereview.chromium.org/550033002/.
6 years, 3 months ago (2014-09-09 16:28:48 UTC) #3
Noam Samuel
lgtm with one tiny nit https://codereview.chromium.org/557663002/diff/20001/printing/printing_context_win.cc File printing/printing_context_win.cc (right): https://codereview.chromium.org/557663002/diff/20001/printing/printing_context_win.cc#newcode363 printing/printing_context_win.cc:363: // TODO(maruel): bug 1214347 ...
6 years, 3 months ago (2014-09-09 18:49:54 UTC) #5
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/557663002/diff/20001/printing/printing_context_win.cc File printing/printing_context_win.cc (right): https://codereview.chromium.org/557663002/diff/20001/printing/printing_context_win.cc#newcode363 printing/printing_context_win.cc:363: // TODO(maruel): bug 1214347 Get the right browser window ...
6 years, 3 months ago (2014-09-09 19:14:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/557663002/40001
6 years, 3 months ago (2014-09-09 19:33:59 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 179d526adea61aa19a2d5a44ea0a2df7426ee752
6 years, 3 months ago (2014-09-09 19:57:56 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:55:05 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f9d0c0ca61adcc78669177583c701607d70cdb0f
Cr-Commit-Position: refs/heads/master@{#293992}

Powered by Google App Engine
This is Rietveld 408576698