Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 478183005: Added PrintingContext::Delegate to get parent view handle and application locale. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/bd7c981343caf492e552ae6c9498a15bbc38f1c7 Cr-Commit-Position: refs/heads/master@{#291871}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Wed Aug 20 16:26:28 PDT 2014 #

Patch Set 4 : Wed Aug 20 16:46:22 PDT 2014 #

Total comments: 4

Patch Set 5 : Wed Aug 20 16:59:54 PDT 2014 #

Patch Set 6 : Wed Aug 20 17:53:07 PDT 2014 #

Patch Set 7 : Wed Aug 20 18:16:46 PDT 2014 #

Patch Set 8 : #

Total comments: 2

Patch Set 9 : Thu Aug 21 11:00:48 PDT 2014 #

Patch Set 10 : Thu Aug 21 15:30:24 PDT 2014 #

Patch Set 11 : Thu Aug 21 15:53:08 PDT 2014 #

Patch Set 12 : Fri Aug 22 20:49:08 PDT 2014 #

Patch Set 13 : Fri Aug 22 21:10:26 PDT 2014 #

Patch Set 14 : Mon Aug 25 22:26:08 PDT 2014 #

Patch Set 15 : Mon Aug 25 22:30:21 PDT 2014 #

Patch Set 16 : Mon Aug 25 23:50:54 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -205 lines) Patch
M chrome/browser/printing/print_job_manager.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job_manager.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/printing/print_job_worker.h View 1 2 3 4 5 6 7 8 9 10 6 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 1 2 3 4 5 6 7 8 9 10 11 11 chunks +77 lines, -20 lines 0 comments Download
M chrome/browser/printing/printer_query.h View 1 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/printing/printer_query.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +39 lines, -74 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +23 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_print_settings_manager.cc View 1 2 3 4 2 chunks +14 lines, -1 line 0 comments Download
M printing/emf_win_unittest.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M printing/print_job_constants.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -0 lines 0 comments Download
M printing/print_job_constants.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +6 lines, -0 lines 0 comments Download
M printing/printing_context.h View 1 2 3 4 5 6 7 8 6 chunks +20 lines, -9 lines 0 comments Download
M printing/printing_context.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M printing/printing_context_android.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M printing/printing_context_android.cc View 1 2 3 4 5 6 4 chunks +6 lines, -6 lines 0 comments Download
M printing/printing_context_linux.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M printing/printing_context_linux.cc View 1 2 3 3 chunks +6 lines, -7 lines 0 comments Download
M printing/printing_context_mac.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M printing/printing_context_mac.mm View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M printing/printing_context_no_system_dialog.cc View 1 2 3 4 5 6 3 chunks +7 lines, -7 lines 0 comments Download
M printing/printing_context_win.h View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M printing/printing_context_win.cc View 1 2 3 4 1 chunk +8 lines, -6 lines 0 comments Download
M printing/printing_context_win_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 46 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-20 23:50:28 UTC) #1
Vitaly Buka (NO REVIEWS)
+inferno for chrome/common/print_messages.h
6 years, 4 months ago (2014-08-20 23:53:07 UTC) #2
Vitaly Buka (NO REVIEWS)
+yzshen for content\browser\renderer_host\pepper\pepper_print_settings_manager.cc
6 years, 4 months ago (2014-08-20 23:55:13 UTC) #3
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-20 23:57:04 UTC) #4
Noam Samuel
lgtm https://codereview.chromium.org/478183005/diff/60001/chrome/browser/printing/print_job_worker.cc File chrome/browser/printing/print_job_worker.cc (right): https://codereview.chromium.org/478183005/diff/60001/chrome/browser/printing/print_job_worker.cc#newcode51 chrome/browser/printing/print_job_worker.cc:51: base::WeakPtrFactory<PrintingContextDelegate> weak_ptr_factory_; Should be last. https://codereview.chromium.org/478183005/diff/60001/chrome/browser/printing/print_job_worker.cc#newcode127 chrome/browser/printing/print_job_worker.cc:127: BrowserThread::DeleteSoon( ...
6 years, 4 months ago (2014-08-21 00:03:53 UTC) #5
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/478183005/diff/60001/chrome/browser/printing/print_job_worker.cc File chrome/browser/printing/print_job_worker.cc (right): https://codereview.chromium.org/478183005/diff/60001/chrome/browser/printing/print_job_worker.cc#newcode51 chrome/browser/printing/print_job_worker.cc:51: base::WeakPtrFactory<PrintingContextDelegate> weak_ptr_factory_; On 2014/08/21 00:03:53, Noam Samuel wrote: > ...
6 years, 4 months ago (2014-08-21 01:19:16 UTC) #6
yzshen1
LGTM for *pepper* https://codereview.chromium.org/478183005/diff/140001/printing/printing_context.h File printing/printing_context.h (right): https://codereview.chromium.org/478183005/diff/140001/printing/printing_context.h#newcode37 printing/printing_context.h:37: // Return parent view to use ...
6 years, 4 months ago (2014-08-21 17:55:21 UTC) #7
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/478183005/diff/140001/printing/printing_context.h File printing/printing_context.h (right): https://codereview.chromium.org/478183005/diff/140001/printing/printing_context.h#newcode37 printing/printing_context.h:37: // Return parent view to use for modal dialogs. ...
6 years, 4 months ago (2014-08-21 18:00:56 UTC) #8
Vitaly Buka (NO REVIEWS)
+thestig chrome/renderer/chrome_mock_render_thread.* +jschuh chrome/common/print_messages.h
6 years, 4 months ago (2014-08-21 18:29:31 UTC) #9
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-21 21:03:19 UTC) #10
jschuh
ipc security lgtm. (notes: using render_view_id for routing and request tracking purposes)
6 years, 4 months ago (2014-08-21 21:17:57 UTC) #11
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-21 21:57:58 UTC) #12
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-21 21:58:36 UTC) #13
Vitaly Buka (NO REVIEWS)
On 2014/08/21 00:03:53, Noam Samuel wrote: > lgtm > > https://codereview.chromium.org/478183005/diff/60001/chrome/browser/printing/print_job_worker.cc > File chrome/browser/printing/print_job_worker.cc (right): ...
6 years, 4 months ago (2014-08-21 22:33:16 UTC) #14
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-21 22:33:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/478183005/200001
6 years, 4 months ago (2014-08-21 22:34:22 UTC) #16
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-21 22:53:19 UTC) #17
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-21 22:53:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/478183005/220001
6 years, 4 months ago (2014-08-21 22:59:31 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 23:55:45 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 00:01:01 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8260)
6 years, 4 months ago (2014-08-22 00:01:03 UTC) #22
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-22 00:16:32 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/478183005/220001
6 years, 4 months ago (2014-08-22 00:20:45 UTC) #24
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-22 01:00:59 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/478183005/240001
6 years, 4 months ago (2014-08-22 01:01:07 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 01:58:51 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 02:57:28 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1205)
6 years, 4 months ago (2014-08-22 02:57:29 UTC) #29
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-23 03:48:59 UTC) #30
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-23 03:49:10 UTC) #31
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-23 03:50:37 UTC) #32
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-23 04:25:22 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/478183005/360001
6 years, 4 months ago (2014-08-23 04:55:50 UTC) #34
commit-bot: I haz the power
Committed patchset #13 (360001) as ee8f4e4029c09ba77e7dbb8fddd85186642b3de8
6 years, 4 months ago (2014-08-23 21:28:31 UTC) #35
Finnur
A revert of this CL (patchset #13) has been created in https://codereview.chromium.org/504763002/ by finnur@chromium.org. The ...
6 years, 3 months ago (2014-08-25 10:07:36 UTC) #36
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-26 05:32:34 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/478183005/400001
6 years, 3 months ago (2014-08-26 05:33:13 UTC) #38
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-26 06:43:16 UTC) #39
Vitaly Buka (NO REVIEWS)
Patchset #17 (id:440001) has been deleted
6 years, 3 months ago (2014-08-26 06:47:21 UTC) #40
Vitaly Buka (NO REVIEWS)
Patchset #16 (id:420001) has been deleted
6 years, 3 months ago (2014-08-26 06:47:30 UTC) #41
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-26 06:58:26 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/478183005/450001
6 years, 3 months ago (2014-08-26 07:00:08 UTC) #43
Vitaly Buka (NO REVIEWS)
Committed patchset #16 to pending queue manually as 3edf7d9 (presubmit successful).
6 years, 3 months ago (2014-08-26 08:59:35 UTC) #44
commit-bot: I haz the power
Patchset 16 (id:??) landed as https://crrev.com/effe183eae93f6a633c7d3a8e88e77d11e737924 Cr-Commit-Position: refs/heads/master@{#291584}
6 years, 3 months ago (2014-09-10 02:31:06 UTC) #45
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:34 UTC) #46
Message was sent while issue was closed. 
Patchset 16 (id:??) landed as
https://crrev.com/bd7c981343caf492e552ae6c9498a15bbc38f1c7
Cr-Commit-Position: refs/heads/master@{#291871}

Powered by Google App Engine
This is Rietveld 408576698