Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 557653002: Revert of Go back to old underline position and thickness logic (Closed)

Created:
6 years, 3 months ago by keishi
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Go back to old underline position and thickness logic (patchset #2 id:20001 of https://codereview.chromium.org/550163003/) Reason for revert: Many tests failed on WinXP because of different underline position. Original issue's description: > Go back to old underline position and thickness logic > > In r174431 from May this year we changed the underline position and > thickness logic to respect the underline data specified in the font. > While this improved rendering for certain fonts and scripts it did cause > a regression for others. This change reverts to the old behavior while > we figure out how to handle fonts with inaccurate or undesirable > metrics. > > BUG=408075 > R=scottmg@chromium.org, cpu@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181591 TBR=scottmg@chromium.org,cpu@chromium.org,eae@chromium.org NOTREECHECKS=true NOTRY=true BUG=408075 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -98 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -98 lines 0 comments Download
M Source/platform/fonts/skia/SimpleFontDataSkia.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
keishi
Created Revert of Go back to old underline position and thickness logic
6 years, 3 months ago (2014-09-09 05:08:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/557653002/1
6 years, 3 months ago (2014-09-09 05:09:07 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 05:09:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181607

Powered by Google App Engine
This is Rietveld 408576698