Go back to old underline position and thickness logic

Go back to old underline position and thickness logic

In r174431 from May this year we changed the underline position and
thickness logic to respect the underline data specified in the font.
While this improved rendering for certain fonts and scripts it did cause
a regression for others. This change reverts to the old behavior while
we figure out how to handle fonts with inaccurate or undesirable
metrics.

BUG=408075
R=scottmg@chromium.org, cpu@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181591

[eae, 2014-09-08 23:42:22]

eae@chromium.org changed reviewers:
+ cpu@chromium.org, scottmg@chromium.org

[scottmg, 2014-09-08 23:50:36]

The default seems to be 0, it doesn't need to do something like?

https://codereview.chromium.org/295923006/diff/20001/Source/platform/fonts/sk...

[scottmg, 2014-09-08 23:52:07]

Sorry, that was just applying it it looks like.

Assuming something sensible is done when it's 0, lgtm.

[eae, 2014-09-08 23:54:42]

On 2014/09/08 23:52:07, scottmg wrote:
> Sorry, that was just applying it it looks like.
> 
> Assuming something sensible is done when it's 0, lgtm.

Yeah, zero indicates the default behavior and matches what we had before.

[eae, 2014-09-08 23:54:45]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-09-08 23:55:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eae@chromium.org/550163003/20001

[commit-bot: I haz the power, 2014-09-09 00:57:47]

Committed patchset #2 (id:20001) as 181591

[keishi, 2014-09-09 05:08:03]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/557653002/ by keishi@chromium.org.

The reason for reverting is: Many tests failed on WinXP because of different
underline position..

[eae, 2014-09-09 15:18:32]

On 2014/09/09 05:08:03, keishi wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/557653002/ by mailto:keishi@chromium.org.
> 
> The reason for reverting is: Many tests failed on WinXP because of different
> underline position..

Sigh. Stupid lack of try bots. 
Those tests just needs to be rebaselined. Will re-land with updated
expectations.

[eae, 2014-09-09 15:29:19]

Patchset #3 (id:40001) has been deleted